[ADE-152] glue input and output of document-processor #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update ReportItem component accordingly
…e file type validation
…al' field and update related tests and documentation
…ggestions fields for lab values
…itialize in ReportsService
- Updated package.json to include @aws-sdk/client-s3 for S3 operations. - Enhanced DocumentProcessorController to process files from S3 using a file path. - Implemented getFileFromS3 method to retrieve files from S3 and streamToBuffer to convert streams to buffers. - Integrated ReportsService to fetch report records based on file paths and user IDs. - Added findByFilePath and updateReport methods in ReportsService for report management. - Improved error handling and logging throughout the new functionality.
…kage.json and package-lock.json; improve error handling in AwsSecretsService
…ntProcessorController to use ConfigService
…s in DocumentProcessorController and ReportsService
… null values in DocumentProcessorController
Contributor
There was a problem hiding this comment.
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (1)
- backend/package.json: Language not supported
Comments suppressed due to low confidence (2)
backend/src/reports/reports.service.ts:33
- The configuration key 'aws.aws.accessKeyId' appears redundant; consider verifying if this is intentional or if it should be simplified to 'aws.accessKeyId' for consistency.
const accessKeyId = this.configService.get<string>('aws.aws.accessKeyId');
backend/src/reports/reports.service.ts:37
- Avoid using the 'any' type for clientOptions; consider defining a proper type for improved type safety and clarity in configuration settings.
const clientOptions: any = { region };
GuidoBR
approved these changes
Apr 15, 2025
backend/src/document-processor/services/aws-bedrock.service.spec.ts
Outdated
Show resolved
Hide resolved
…sis and Report models for consistency
…elated tests for simplification
…dels for enhanced lab value analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This pull request includes several updates to the backend, primarily focusing on enhancing the document processing capabilities and improving the configuration management. Key changes include updating dependencies, modifying middleware configurations, adding new configuration settings, and expanding the functionality of the
DocumentProcessorController.Dependency Updates:
@aws-sdk/client-s3to version^3.787.0inbackend/package.json.@typescript-eslint/eslint-pluginand@typescript-eslint/parserto version^8.30.1inbackend/package.json.Middleware and Configuration Enhancements:
AuthMiddlewareto exclude specific routes inbackend/src/app.module.ts.backend/src/config/configuration.ts. [1] [2]Document Processing Improvements:
DocumentProcessorControllerto include new methods for processing documents from S3 and handling errors more effectively inbackend/src/document-processor/controllers/document-processor.controller.ts. [1] [2] [3] [4]ReportsModuleto theDocumentProcessorModuleinbackend/src/document-processor/document-processor.module.ts.Medical Document Analysis Enhancements:
MedicalDocumentAnalysisinterface to include additional fields liketitle,category,conclusion, andsuggestionsinbackend/src/document-processor/services/aws-bedrock.service.ts. [1] [2] [3] [4] [5] [6]Testing Improvements:
backend/src/document-processor/services/aws-bedrock.service.spec.tsandbackend/src/document-processor/services/aws-textract.service.spec.ts. [1] [2] [3] [4] [5] [6] [7]Does this PR introduce a breaking change?
{...}
What needs to be documented once your changes are merged?
{...}
Additional Comments
{...}