Skip to content

Conversation

@adamrefaey
Copy link
Collaborator

@adamrefaey adamrefaey commented Apr 17, 2025

Change

followup to implementing the frontend of processing and showing the reports

Does this PR introduce a breaking change?

{...}

What needs to be documented once your changes are merged?

{...}

Additional Comments

{...}

@adamrefaey adamrefaey self-assigned this Apr 17, 2025
@adamrefaey adamrefaey changed the title fix: Change timeoutRef type to number for consistency with setTimeout followup to implementing the frontend of processing and showing the reports Apr 17, 2025
@adamrefaey adamrefaey changed the title followup to implementing the frontend of processing and showing the reports [ADE-66] followup to implementing the frontend of processing and showing the reports Apr 17, 2025
@adamrefaey adamrefaey requested a review from Copilot April 17, 2025 18:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request follows up on the frontend implementation for processing and displaying reports and adds new backend permissions for document analysis using Amazon Textract.

  • Update the useTimeout hook to use the browser-appropriate timeout type.
  • Add Textract permissions to the backend stack for document analysis.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
frontend/src/common/hooks/useTimeout.ts Updated the timeout reference type to better align with browser APIs.
backend/src/iac/backend-stack.ts Added Textract permissions for document analysis while noting potential production resource restrictions.
Comments suppressed due to low confidence (1)

frontend/src/common/hooks/useTimeout.ts:7

  • [nitpick] Ensure that using the number type for timeoutRef is intentional and appropriate for the browser environment, as Node environments expect NodeJS.Timeout.
const timeoutRef = useRef<number | null>(null);

@GuidoBR GuidoBR merged commit b79f053 into main Apr 17, 2025
2 checks passed
@adamrefaey adamrefaey deleted the ADE-66 branch April 17, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants