Skip to content

Conversation

@adamrefaey
Copy link
Collaborator

@adamrefaey adamrefaey commented Apr 18, 2025

Change

This pull request introduces several changes to both the backend and frontend codebases. On the backend, a new API resource and method for retrieving report statuses has been added under the document-processor resource. On the frontend, new icons are added to the Icon component, and minor formatting adjustments are made to the TabNavigation component. Below is a breakdown of the most important changes:

Backend Changes: New API Resource for Report Status

  • Added a new report-status/{reportId} resource under the document-processor API, including integration with an HTTP proxy to retrieve report statuses. (backend/src/iac/backend-stack.ts, [1] [2]
  • Defined a GET method for the report-status/{reportId} resource, including request parameter mapping and authorization options. (backend/src/iac/backend-stack.ts, backend/src/iac/backend-stack.tsR514-R520)
  • Configured CORS for the new report-status/{reportId} resource to allow cross-origin requests. (backend/src/iac/backend-stack.ts, backend/src/iac/backend-stack.tsR560-R564)

Frontend Changes: Icon Component Updates

  • Added new icons (flag, flask, chevronUp, chevronDown, vial) to the Icon component, including updates to the IconName type and solidIcons mapping. (frontend/src/common/components/Icon/Icon.tsx, [1] [2] [3]
  • Minor formatting cleanup in the Icon component for better readability. (frontend/src/common/components/Icon/Icon.tsx, frontend/src/common/components/Icon/Icon.tsxL157-R173)

Frontend Changes: TabNavigation Component

Does this PR introduce a breaking change?

{...}

What needs to be documented once your changes are merged?

{...}

Additional Comments

{...}

@adamrefaey adamrefaey self-assigned this Apr 18, 2025
@adamrefaey adamrefaey changed the title [ADE-66] create ReportDetailPage [ADE-66] create ReportDetailPage & add report-status api gateway endpoint Apr 18, 2025
@adamrefaey adamrefaey requested review from GuidoBR and Copilot April 18, 2025 17:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a new report status API endpoint in the backend and updates the frontend components for report details and navigation styling.

  • Added new API resource and GET method for report statuses in the backend.
  • Updated the Icon component with new icons and improved the formatting in TabNavigation for better readability.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
frontend/src/common/components/Router/TabNavigation.tsx Adjusted import order and reformatted JSX for consistency.
frontend/src/common/components/Icon/Icon.tsx Added new icon mappings and updated the IconName type and icon selection formatting.
backend/src/iac/backend-stack.ts Introduced new report-status API resource, added GET method integration, and configured CORS.

@adamrefaey adamrefaey merged commit 4606170 into main Apr 18, 2025
2 checks passed
@adamrefaey adamrefaey deleted the ADE-66 branch April 18, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants