[ADE-66] fixes, refactors, and adding icons to processing and viewing reports #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new SVG icons: info.svg, normal-values.svg, and warning.svg. - Updated ProcessingPage styles for better layout and animation. - Refactored ProcessingAnimation component to use new AI icon. - Enhanced ProcessingError component with new warning icon and improved styling. - Updated ReportDetailPage styles to include active bookmark button styling. - Refactored FlaggedValuesSection and NormalValuesSection to use new SVG icons. - Created InfoCard component with associated styles for displaying information. - Updated LowConfidenceNotice to use new info icon. - Refactored ReportHeader to use new close and bookmark icons. - Updated ReportTabs to use new AI insights icon.
adamrefaey
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on fixing and refactoring UI components for processing and viewing reports, with an emphasis on replacing inline SVGs and the Icon component with imported SVG image assets.
- Replaces inline SVGs with
elements in various report and processing components.
- Refactors UI components such as ReportHeader, InfoCard, and ProcessingError to accommodate design updates and new icon assets.
- Updates backend ESLint configuration to use a new parser option.
Reviewed Changes
Copilot reviewed 22 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/pages/Reports/components/ReportTabs.tsx | Replaces inline SVG for AI Insights with an imported image. |
| frontend/src/pages/Reports/components/ReportHeader.tsx | Updates close and bookmark icons to image elements with conditional rendering. |
| frontend/src/pages/Reports/components/NormalValuesSection.tsx | Switches from using Icon to an imported normal values SVG. |
| frontend/src/pages/Reports/components/LowConfidenceNotice.tsx | Replaces IonIcon with an image for the information icon. |
| frontend/src/pages/Reports/components/InfoCard.tsx | Removes translation hook and Icon component in favor of hardcoded text and an imported bulb icon. |
| frontend/src/pages/Reports/components/FlaggedValuesSection.tsx | Replaces Icon with an imported flagged values SVG image. |
| frontend/src/pages/Processing/components/ProcessingError.tsx | Refactors error display using IonButton and an imported warning icon, and removes a fallback error message. |
| frontend/src/pages/Processing/components/ProcessingAnimation.tsx | Adjusts animation container and displays an imported AI icon. |
| backend/.eslintrc.js | Updates ESLint parserOptions by replacing an explicit tsconfig path with projectService. |
Files not reviewed (6)
- backend/tsconfig.json: Language not supported
- frontend/src/pages/Processing/ProcessingPage.scss: Language not supported
- frontend/src/pages/Reports/ReportDetailPage.scss: Language not supported
- frontend/src/pages/Reports/components/InfoCard.scss: Language not supported
- package.json: Language not supported
- tsconfig.eslint.json: Language not supported
Comments suppressed due to low confidence (2)
frontend/src/pages/Reports/components/InfoCard.tsx:1
- Localization support has been removed from InfoCard and replaced with a hardcoded string. If internationalization is required, consider reintroducing the translation hook or using a localization mechanism.
import { useTranslation } from 'react-i18next';
backend/.eslintrc.js:4
- The ESLint configuration now uses 'projectService: true' instead of an explicit tsconfig path. Verify that this change correctly applies the intended TypeScript configuration.
projectService: true, // Changed from project: 'tsconfig.json'
GuidoBR
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
fixes, refactors, and adding icons to processing and viewing reports
Does this PR introduce a breaking change?
{...}
What needs to be documented once your changes are merged?
{...}
Additional Comments
{...}