Conversation
|
hi, this looks like purely formatting change? |
|
Some of it, but there are some changes that I still haven't committed, ergo the draft phase 😅 |
|
thanks in advance! |
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
|
The whitespace (“retabbing”) changes are not necessary in my opinion. They do not add more value to the code and obfuscate the “git blame” feature. |
I think the reason I did it for the notebooks is that since they get picked up by Documenter, it shows up differently on the docs pages. I do agree about the git blame obfuscation thing. I'm going to rebase and remove the whitespace related commits 👍 I would still like to propose that a retabbing PR later be made, with a .git-blame-ignore-revs file to handle the git blame, if that's acceptable? |
Stop Markdown parsers from picking it up as code
Specifies that it should be treated as a hyperlinke
Dependency on FHist.jl already taken care of in docs/Project.toml, the `[sources]` section will make sure it's using the correct version
Markdown was picking it all up as code
More obvious effect of plotting, also looks nicer without the `begin...end` block
|
I think that's a good idea 🙂 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 77.73% 77.73%
=======================================
Files 11 11
Lines 858 858
=======================================
Hits 667 667
Misses 191 191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[sources]attribute in docs/Project.toml, as supported by Pkg.toml v1.11+ for docs to maintain its dependency on FHist itself.This does imply we should run docs on Julia v1.11+, but given that it's essentially a separate environment, and also not what we're promising the registry, it should be fine since CI automatically picks the newest version anyway.
It also lets us do away with the
Pkg.develop()call in the notebooks.Each commit and its associated message contains a more atomic change and its description.