[210_10] 实现 bag 更新/子集/集合运算接口 #395
Merged
+692
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR implements bag update, subset, and set operation interfaces for SRFI-113, completing the core multiset functionality for the bag data structure.
Changes:
- Implements bag update operations (adjoin, replace, delete) with both functional and mutating variants
- Adds bag comparison operators (bag=?, bag<?, bag>?, bag<=?, bag>=?) for subset relationships
- Implements set operations (union, intersection, difference, xor) with both functional and mutating variants
- Adds bag-search! for conditional element lookup and update
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| goldfish/srfi/srfi-113.scm | Implements all bag update, comparison, and set operation functions following SRFI-113 semantics |
| goldfish/liii/bag.scm | Exports the newly implemented bag functions to make them available in the (liii bag) module |
| tests/goldfish/liii/bag-test.scm | Adds comprehensive tests with documentation for all new bag operations |
| devel/210_10.md | Documents the implementation approach and design decisions for the new bag features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.