[210_12] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数 #396

jetjinser · 2026-01-30T09:30:43Z

[210_12] `(srfi srfi-19)`

任务相关的代码文件

src/goldfish.hpp
tests/goldfish/liii/time-test.scm
goldfish/scheme/time.scm
goldfish/srfi/srfi-19.scm

如何测试

# 可能需要清除缓存
# rm .xmake/ build/ -r
xmake f -vyD
xmake b goldfish
./bin/goldfish tests/goldfish/liii/time-test.scm

2026/1/30 初始化 time 和 date 结构

What

新增 glue：g_gettimeofday, g_monotonic-nanosecond, g_steady-clock-resolution, g_system-clock-resolution
实现 time 与 date 基本结构
实现部分 SRFI-19 proc，包括 current-time, date->string 等

Why

扩充时间与日期的支持。

How

通过 C++17 的 chrono 绑定实现。

Copilot

Pull request overview

This PR implements SRFI-19 time and date support for Goldfish Scheme by adding C++17 chrono-based glue functions and comprehensive Scheme implementations of time and date structures with formatting capabilities.

Changes:

Added C++ glue functions for time operations using std::chrono (get-time-of-day, monotonic-nanosecond, clock resolutions)
Implemented SRFI-19 time and date record types with accessors and basic operations
Implemented date-to-string formatting with extensive format specifier support
Added comprehensive test suite covering time/date creation, accessors, and formatting

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
src/goldfish.hpp	Adds C++ glue functions using std::chrono for time operations and clock resolution queries
goldfish/scheme/time.scm	Refactors current-second and current-jiffy to use new glue functions, exports clock resolution constants
goldfish/srfi/srfi-19.scm	Implements SRFI-19 time/date types, current-time, time-resolution, date->string with format specifiers, and leap second handling
tests/goldfish/liii/time-test.scm	Comprehensive test suite for time/date constants, constructors, accessors, formatting, and error conditions
devel/210_12.md	Development documentation describing the implementation approach and testing instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-02T01:31:33Z

goldfish/srfi/srfi-19.scm

+        (cond
+          ((null? table)       10) ; 理论值
+          ((>= s (caar table)) (cdar table))
+          (else                (loop (cdr table))))))


The function uses loop but the binding is named lp. This should be (lp (cdr table)) to match the named let binding on line 218.

Suggested change

(else (loop (cdr table))))))

(else (lp (cdr table))))))

Copilot · 2026-02-02T01:31:34Z

goldfish/srfi/srfi-19.scm

+          ((#\I) (let* ((hr  (date-hour date))
+                        (hr* (if (> hr 12) (- hr 12) hr)))
+                   (display (priv:padding hr* pad-with 2)


The 12-hour conversion logic is incorrect. When the hour is exactly 12, it should remain 12 (noon/midnight display as 12, not 0). The condition should be: if hr is 0, use 12; otherwise if hr > 12, use hr - 12; otherwise use hr. Currently, hour 12 will be displayed as 12 which is correct, but hour 0 will be displayed as 0 instead of 12.

Copilot · 2026-02-02T01:31:34Z

goldfish/srfi/srfi-19.scm

+            (priv:date-printer date format-string
+                               format-string-port port)))))
+
+    (define* (date->string date (format-string "~c"))


Missing type check for the date parameter. The function should verify that date is actually a date object and raise a wrong-type-arg error if not, consistent with other SRFI-19 procedures.

Suggested change

(define* (date->string date (format-string "~c"))

(define* (date->string date (format-string "~c"))

(unless (date? date)

(wrong-type-arg 'date->string 1 "date" date))

Copilot · 2026-02-02T01:31:34Z

goldfish/srfi/srfi-19.scm

+            (priv:date-printer date format-string
+                               format-string-port port)))))
+
+    (define* (date->string date (format-string "~c"))


Missing type check for the format-string parameter. The function should verify that format-string is actually a string and raise a wrong-type-arg error if not, as tested in the test file at lines 788-789.

Suggested change

(define* (date->string date (format-string "~c"))

(define* (date->string date (format-string "~c"))

(unless (string? format-string)

(wrong-type-arg 'date->string format-string))

Copilot · 2026-02-02T01:31:34Z

devel/210_12.md

+
+### What
+
+1. 新增 glue：`g_gettimeofday`, `g_monotonic-nanosecond`, `g_steady-clock-resolution`, `g_system-clock-resolution`


Typo in the documentation: it says g_gettimeofday but the actual function name is g_get-time-of-day (with hyphens instead of no separators).

Suggested change

1. 新增 glue：`g_gettimeofday`, `g_monotonic-nanosecond`, `g_steady-clock-resolution`, `g_system-clock-resolution`

1. 新增 glue：`g_get-time-of-day`, `g_monotonic-nanosecond`, `g_steady-clock-resolution`, `g_system-clock-resolution`

Copilot · 2026-02-02T01:31:35Z

src/goldfish.hpp

+             s7_make_typed_function (sc, s_get_time_of_day, f_get_time_of_day, 0, 0, false, d_get_time_of_day, NULL));
+
+  const char* s_monotonic_nanosecond= "g_monotonic-nanosecond";
+  const char* d_monotonic_nanosecond= "(g_monotonic-nanosecond): () => integer, TODO";


The documentation string should be updated to describe what this function actually returns. It currently says "TODO" but should explain that it returns the steady clock's monotonic nanoseconds since an unspecified epoch.

Suggested change

const char* d_monotonic_nanosecond= "(g_monotonic-nanosecond): () => integer, TODO";

const char* d_monotonic_nanosecond= "(g_monotonic-nanosecond): () => integer, returns the steady clock's monotonic nanoseconds since an unspecified epoch";

Copilot · 2026-02-02T01:31:36Z

goldfish/srfi/srfi-19.scm

+               ;; 归前一年：判断前一年52周还是53周（周四年首=53周）
+               (if (> (priv:week-day 1 1 (- year 1)) 4) 52 53))


The ISO-8601 week number logic at line 399 has an incorrect condition. For ISO-8601, a year has 53 weeks if January 1st falls on a Thursday (4) OR if it's a leap year and January 1st falls on a Wednesday (3). The current check (> (priv:week-day 1 1 (- year 1)) 4) tests if the first day of the previous year is greater than 4 (Friday or Saturday), which would give 52 weeks. This appears backwards - it should check if the previous year's Jan 1 was on Thursday (or Wednesday for leap years) to determine 53 weeks.

Suggested change

;; 归前一年：判断前一年52周还是53周（周四年首=53周）

(if (> (priv:week-day 1 1 (- year 1)) 4) 52 53))

;; 归前一年：判断前一年52周还是53周

;; ISO-8601: 前一年有53周当且仅当：该年1月1日是周四，

;; 或者该年是闰年且1月1日是周三。

(let* ((prev-year (- year 1))

(prev-jan1-wday (priv:week-day 1 1 prev-year))

(prev-leap?

(or (and (zero? (modulo prev-year 4))

(not (zero? (modulo prev-year 100))))

(zero? (modulo prev-year 400)))))

(if (or (= prev-jan1-wday 4)

(and prev-leap? (= prev-jan1-wday 3)))

53

52)))

Copilot · 2026-02-02T01:31:36Z

goldfish/srfi/srfi-19.scm

+  (import (rename (scheme time)
+                  (get-time-of-day      glue:get-time-of-day)
+                  (monotonic-nanosecond glue:monotonic-nanosecond))
+          (only (srfi srfi-13) string-pad string-tokenize string-trim-right)


The library uses receive (lines 225, 232, 241, 442) but doesn't import it. It should import receive from (srfi srfi-8) or another module that provides it.

Suggested change

(only (srfi srfi-13) string-pad string-tokenize string-trim-right)

(only (srfi srfi-13) string-pad string-tokenize string-trim-right)

(only (srfi srfi-8) receive)

Copilot · 2026-02-02T01:31:36Z

goldfish/srfi/srfi-19.scm

+      (let* ((str     (number->string n))
+             (str-len (string-length str)))
+        (cond
+          ((or (> str-len len) (not pad-with)) str)
+          (else (string-pad str len pad-with)))))


The padding function doesn't handle negative numbers correctly. When a negative number is converted to a string, the minus sign becomes part of the string, and padding will insert zeros/spaces after the minus sign (e.g., "-001" instead of "-01"). For proper formatting, the sign should be extracted first, and padding applied to the absolute value, then the sign prepended.

Suggested change

(let* ((str (number->string n))

(str-len (string-length str)))

(cond

((or (> str-len len) (not pad-with)) str)

(else (string-pad str len pad-with)))))

(let* ((str (number->string n))

(str-len (string-length str))

(negative? (and (> str-len 0)

(char=? (string-ref str 0) #\-)))

(sign (if negative? "-" ""))

(core (if negative?

(substring str 1 str-len)

str))

(core-len (string-length core))

;; For negative numbers, the requested length includes the sign,

;; so we reserve one character for it when padding the digits.

(target-len (if negative?

(max 0 (- len 1))

len)))

(cond

((or (> (+ core-len (if negative? 1 0)) len)

(not pad-with))

str)

(else

(string-append

sign

(string-pad core target-len pad-with))))))

Copilot · 2026-02-02T01:31:36Z

goldfish/srfi/srfi-19.scm

+  (import (rename (scheme time)
+                  (get-time-of-day      glue:get-time-of-day)
+                  (monotonic-nanosecond glue:monotonic-nanosecond))
+          (only (srfi srfi-13) string-pad string-tokenize string-trim-right)


The library uses floor/ (lines 225, 443) but doesn't import it. It should import floor/ from (scheme base) or another module that provides it.

Suggested change

(only (srfi srfi-13) string-pad string-tokenize string-trim-right)

(only (srfi srfi-13) string-pad string-tokenize string-trim-right)

(only (scheme base) floor/)

jetjinser added 2 commits January 30, 2026 17:24

feat(srfi-19): init

10b7305

docs(devel): add 210_10

fef67be

jetjinser marked this pull request as ready for review January 30, 2026 09:30

docs(devel): 210_10 -> 210_11

6b21b82

jetjinser changed the title ~~[210_10] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数~~ [210_11] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数 Jan 30, 2026

jetjinser changed the title ~~[210_11] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数~~ [210_12] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数 Jan 30, 2026

docs(devel): 210_11 -> 210_12

b0c90a4

jetjinser force-pushed the jinser/srfi-19-init branch from d2ba472 to b0c90a4 Compare January 30, 2026 09:32

fix(srfi-19): import (liii error)

3046b37

MoonL79 requested a review from Copilot February 2, 2026 01:26

Copilot started reviewing on behalf of MoonL79 February 2, 2026 01:26 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[210_12] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数 #396

[210_12] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数 #396

Uh oh!

jetjinser commented Jan 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		### What

		1. 新增 glue：`g_gettimeofday`, `g_monotonic-nanosecond`, `g_steady-clock-resolution`, `g_system-clock-resolution`

	1. 新增 glue：`g_gettimeofday`, `g_monotonic-nanosecond`, `g_steady-clock-resolution`, `g_system-clock-resolution`
	1. 新增 glue：`g_get-time-of-day`, `g_monotonic-nanosecond`, `g_steady-clock-resolution`, `g_system-clock-resolution`

	const char* d_monotonic_nanosecond= "(g_monotonic-nanosecond): () => integer, TODO";
	const char* d_monotonic_nanosecond= "(g_monotonic-nanosecond): () => integer, returns the steady clock's monotonic nanoseconds since an unspecified epoch";

		;; 归前一年：判断前一年52周还是53周（周四年首=53周）
		(if (> (priv:week-day 1 1 (- year 1)) 4) 52 53))

-               ;; 归前一年：判断前一年52周还是53周（周四年首=53周）
-               (if (> (priv:week-day 1 1 (- year 1)) 4) 52 53))
+               ;; 归前一年：判断前一年52周还是53周
+               ;; ISO-8601: 前一年有53周当且仅当：该年1月1日是周四，
+               ;; 或者该年是闰年且1月1日是周三。
+               (let* ((prev-year (- year 1))
+                      (prev-jan1-wday (priv:week-day 1 1 prev-year))
+                      (prev-leap?
+                        (or (and (zero? (modulo prev-year 4))
+                                 (not (zero? (modulo prev-year 100))))
+                            (zero? (modulo prev-year 400)))))
+                 (if (or (= prev-jan1-wday 4)
+                         (and prev-leap? (= prev-jan1-wday 3)))
+)))

	(only (srfi srfi-13) string-pad string-tokenize string-trim-right)
	(only (srfi srfi-13) string-pad string-tokenize string-trim-right)
	(only (srfi srfi-8) receive)

-      (let* ((str     (number->string n))
-             (str-len (string-length str)))
-        (cond
-          ((or (> str-len len) (not pad-with)) str)
-          (else (string-pad str len pad-with)))))
+      (let* ((str      (number->string n))
+             (str-len  (string-length str))
+             (negative? (and (> str-len 0)
+                             (char=? (string-ref str 0) #\-)))
+             (sign     (if negative? "-" ""))
+             (core     (if negative?
+                           (substring str 1 str-len)
+                           str))
+             (core-len (string-length core))
+             ;; For negative numbers, the requested length includes the sign,
+             ;; so we reserve one character for it when padding the digits.
+             (target-len (if negative?
+                              (max 0 (- len 1))
+                              len)))
+        (cond
+          ((or (> (+ core-len (if negative? 1 0)) len)
+               (not pad-with))
+           str)
+          (else
+            (string-append
+              sign
+              (string-pad core target-len pad-with))))))

	(only (srfi srfi-13) string-pad string-tokenize string-trim-right)
	(only (srfi srfi-13) string-pad string-tokenize string-trim-right)
	(only (scheme base) floor/)

[210_12] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数 #396

Are you sure you want to change the base?

[210_12] feat(srfi-19): 初始化 time 和 date 结构，实现部分函数 #396

Uh oh!

Conversation

jetjinser commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[210_12] (srfi srfi-19)

任务相关的代码文件

如何测试

2026/1/30 初始化 time 和 date 结构

What

Why

How

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jetjinser commented Jan 30, 2026 •

edited

Loading

[210_12] `(srfi srfi-19)`