Update regex crate to support empty sub expressions in alternations#1
Draft
Update regex crate to support empty sub expressions in alternations#1
Conversation
Author
|
Im not sure of the exact release process for this repository so I will leave this PR as a draft for now. |
Author
|
I increased the patch version for the acpplinter because the patch version of a dependency was updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a regex to the mcpe-linter.json an error occurred while using an empty sub expression in a regex alternation. This functionality was added in the rust regex crate version 1.3.8. The default behavior of cargo is to grab the latest compatible version of the crate. In the pipelines we download the pre built linter exe from the Mojang/acpplinter releases github page. In order to reduce the amount of regex expressions in the mcpe linter file we should explicitly update the regex crate to 1.3.8.
More information in the original PR this empty sub expression functionality was used in.