-
Notifications
You must be signed in to change notification settings - Fork 11
AABBUtils and Vector3Utils.ceil #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae95cbe to
ddf9033
Compare
ddf9033 to
a26c746
Compare
AlexDenfordSkyboxLabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome great work! Test coverage looks good, implementations make sense to me, happy to see thorough docs/comments etc. Thanks!
rlandav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version fix is the only true blocking change. The rest are mock suggestions, and elevating some repeated logic you had to a genneral purpose Vector3 helper.
Also, do you think there is value in an a builder style variant of AABB utils akin to the Vector3Builder, or is the functional pattern the only one you see as necessary?
change/@minecraft-math-13da4e91-9583-4450-b4b9-a00da5a6a7c9.json
Outdated
Show resolved
Hide resolved
The Vector3Builder is likely to be more widely used - though AABBBuilder could be worth visiting in a second PR. Some ideas for how that would be useful maybe |
change/@minecraft-math-13da4e91-9583-4450-b4b9-a00da5a6a7c9.json
Outdated
Show resolved
Hide resolved
…t-scripting-libraries into niamh.cuileann/aabbutils
…eil core helpers and builder. Updated to use min/max in AABBUtils.
|
@rlandav Updated to add min/max to Vector3Utils, also added ceil/min/max to Vector3Builder since I missed that previously with tests for all of those additions. Changed everything internally to use Vector3Utils.min/max as well since there were a few spots that did that manually. Updated the beachball changelog. |
Description
AABBUtilsfor working withAABB, taking inspiration fromVector3Utils.AABBUtilswith mockedBlockVolume.Vector3Utils.ceilwith tests to match theVector3Utils.floor(used byAABBUtils).api-extractor.jsonandjust.config.ctssince they pointed to incorrect paths.package-lock.jsonusingnpm update @minecraft/serverfromv2.0.0tov2.4.0to get access to theAABBinterface.Reviewing
BlockVolumemock floors it's from/to coordinates since internally it usesBlockPosthat converts floating point numbers to integer using floor.