Open
Conversation
Collaborator
loriab
commented
Aug 28, 2019
loriab
commented
- this one test passes but not ready for merging
dgasmith
reviewed
Sep 3, 2019
|
|
||
| _defaults = { | ||
| "name": "PylibEFP", | ||
| "scratch": False, |
Collaborator
There was a problem hiding this comment.
This is probably thread safe?
Collaborator
Author
There was a problem hiding this comment.
all in memory and all functions acting on same struct instance, so yes.
| import qcengine as qcng | ||
| from qcengine.testing import using_pylibefp | ||
|
|
||
| b2a = 0.529177 |
Collaborator
There was a problem hiding this comment.
I assume efp uses its own conversion? Can we add a comment here about that.
Collaborator
Author
There was a problem hiding this comment.
I'll look it up, but this particular one is just to get the geometry in with both round numbers and to match the answers taken from libefp test suite. outputs are all in Eh, a0. So this conversion isn't a broad concern.
Collaborator
There was a problem hiding this comment.
Makes sense. Should be fine as long as we note it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.