Skip to content

Add Gaussian harness#442

Open
QuChem wants to merge 36 commits intoMolSSI:masterfrom
QuChem:QuChem-gaussian-added
Open

Add Gaussian harness#442
QuChem wants to merge 36 commits intoMolSSI:masterfrom
QuChem:QuChem-gaussian-added

Conversation

@QuChem
Copy link
Copy Markdown

@QuChem QuChem commented Feb 14, 2024

Description

This is the implementation of Gaussian software into QCEngine

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 191 lines in your changes missing coverage. Please review.

Project coverage is 78.18%. Comparing base (1b27a14) to head (aad52cf).
Report is 7 commits behind head on master.

Current head aad52cf differs from pull request most recent head a2ff5c8

Please upload reports for the commit a2ff5c8 to get more accurate results.

Additional details and impacted files

Comment thread qcengine/programs/gaussian.py Outdated
Comment on lines +128 to +129
#if input_model.molecule.fix_com or input_model.molecule.fix_orientation:
# keywords["SYM_IGNORE"] = "TRUE"

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.
Comment on lines +207 to +209
#if input_model.driver == 'energy':
# print (cclib.__version__)
# print (output_data)

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.
Comment thread qcengine/programs/gaussian.py Outdated
"""

import os
import re

Check notice

Code scanning / CodeQL

Unused import

Import of 're' is not used.
Comment thread qcengine/programs/gaussian.py Outdated

import os
import re
import tempfile

Check notice

Code scanning / CodeQL

Unused import

Import of 'tempfile' is not used.
Comment thread qcengine/programs/gaussian.py Outdated
import os
import re
import tempfile
import warnings

Check notice

Code scanning / CodeQL

Unused import

Import of 'warnings' is not used.
Comment thread qcengine/programs/gaussian.py Outdated
data = cclib.io.ccread(tmp_output_file)
cclib_vars = data.getattributes(True)

last_occupied_energy = data.moenergies[0][data.homos[0]]

Check notice

Code scanning / CodeQL

Unused local variable

Variable last_occupied_energy is not used.
Comment thread qcengine/programs/gaussian.py Fixed
Comment thread qcengine/programs/gaussian.py Outdated

provenance = Provenance(creator="Gaussian", version=self.get_version(), routine='g09').dict()

stdout = outfiles.pop('stdout')

Check notice

Code scanning / CodeQL

Unused local variable

Variable stdout is not used.
Comment thread qcengine/programs/gaussian.py Outdated
provenance = Provenance(creator="Gaussian", version=self.get_version(), routine='g09').dict()

stdout = outfiles.pop('stdout')
stderr = outfiles.pop('stderr')

Check notice

Code scanning / CodeQL

Unused local variable

Variable stderr is not used.
Comment thread qcengine/programs/gaussian.py Outdated
#print("\nPRINT STDOUT: \n", stdout)


method = input_model.model.method.lower()

Check notice

Code scanning / CodeQL

Unused local variable

Variable method is not used.
@bennybp bennybp changed the title QuChem gaussian added Add Gaussian harness Feb 14, 2024
@bennybp
Copy link
Copy Markdown
Collaborator

bennybp commented Feb 16, 2024

I think programs.py should be base.py inside the programs folder. You should modify that file with your changes

Comment thread qcengine/programs/gaussian.py Outdated
output_data['success'] = True
#print ('output_data: ', output_data)

provenance = Provenance(creator="gaussian", version=self.get_version(), routine='g09').dict()

Check notice

Code scanning / CodeQL

Unused local variable

Variable provenance is not used.
Copy link
Copy Markdown
Collaborator

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Here's some initial queries.

Comment thread qcengine/programs/gaussian.py Outdated
Comment thread qcengine/programs/gaussian.py Outdated
#if input_model.molecule.fix_com or input_model.molecule.fix_orientation:
# keywords["SYM_IGNORE"] = "TRUE"
if 'SCF_CONVERGENCE' in keywords:
gaussian_kw.append('SCF=' + keywords["SCF_CONVERGENCE"])
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the name "SCF_CONVERGENCE" coming from? QCNG tends to want the same keyword names in AtIn.keywords as the experience user would use in the program natively. Is Conver=N on https://gaussian.com/scf/ ("Options" tab) what you're targeting?

Comment thread qcengine/programs/gaussian.py
Comment thread qcengine/programs/gaussian.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants