Skip to content

Making dataset views should always include required record fields #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bennybp merged 1 commit into from
Feb 4, 2026
Merged

Making dataset views should always include required record fields #985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion qcfractal/qcfractal/components/dataset_processing/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from qcportal.cache import DatasetCache
from qcportal.dataset_models import BaseDataset
from qcportal.record_models import RecordStatusEnum, BaseRecord
from qcportal.utils import chunk_iterable
from qcportal.utils import chunk_iterable, make_list

if TYPE_CHECKING:
from sqlalchemy.orm.session import Session
Expand Down Expand Up @@ -129,6 +129,10 @@ def create_view_file(
children_ids = socket.records.get_children_ids(session, record_ids)
all_ids |= set(children_ids)

# Always include the base record information
if include is not None:
include = make_list(include) + ["*"]

############################################################################
# Determine the record types of all the ids (top-level and children if desired)
############################################################################
Expand Down
Loading