Skip to content

Conversation

@berquist
Copy link
Contributor

The reason needs no introduction at this point...

Questions/comments:

  1. There is a problem with building the docs that should be fixed separately:
Traceback (most recent call last):
  File "/home/eric/.pyenv/versions/miniforge3-4.10.1-3/envs/qcsk/lib/python3.7/site-packages/sphinx/config.py", line 327, in eval_config_file
    exec(code, namespace)
  File "/home/eric/development/json/MolSSI_QC_JSON_Schema/docs/source/conf.py", line 26, in <module>
    import gen_schema_docs
  File "/home/eric/development/json/MolSSI_QC_JSON_Schema/docs/source/gen_schema_docs.py", line 14, in <module>
    scf_props = qcschema.dev.properties.scf_properties.scf_properties
AttributeError: module 'qcschema.dev' has no attribute 'properties'
  1. Do you have codecov set up?
  2. The schema files are not actually installed without
diff --git a/setup.py b/setup.py
index 742f1b1..4c27433 100644
--- a/setup.py
+++ b/setup.py
@@ -9,6 +9,7 @@ if __name__ == "__main__":
         url="https://github.com/MolSSI/QCSchema",
         license='',
         packages=setuptools.find_packages(),
+        package_data={"": ["*.schema"]},
         install_requires=[
             'jsonschema',
             'pathlib2; python_version < "3.5"',  # redundant with jsonschema

which also needs to be fixed and tested.

@berquist
Copy link
Contributor Author

berquist commented Sep 1, 2021

Poke for this and #81 (they should be considered together). Without it, we effectively cannot use this repo as a package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant