Skip to content

6 m0 k structure bk work#87

Open
Binikarki wants to merge 3 commits intoMolSSI:masterfrom
Binikarki:6M0K_structure_BK_work
Open

6 m0 k structure bk work#87
Binikarki wants to merge 3 commits intoMolSSI:masterfrom
Binikarki:6M0K_structure_BK_work

Conversation

@Binikarki
Copy link
Copy Markdown
Contributor

Description

Provide a brief description of the data being added here.

Status

  • YAML file for each piece of data
  • Ready to go

@jchodera
Copy link
Copy Markdown
Contributor

@Binikarki : Can you provide a more complete description of the work you are contributing in the title and description of the PRs?

@Binikarki
Copy link
Copy Markdown
Contributor Author

Will do

@Lnaden
Copy link
Copy Markdown
Collaborator

Lnaden commented Apr 23, 2020

This one has a the same problem as #86 in that 6M0K does not exist in RCSB. This also does the same thing as #86, so it would be redundant. I'm willing to bet what happened is that you made #86, then created a branch off of that to make this one instead of checking master back out first.

@Lnaden
Copy link
Copy Markdown
Collaborator

Lnaden commented Apr 24, 2020

@Binikarki With #86 merged, I think if you rebase from current molssi master, and change the 6M0K structure to use the unpublished_pdbid tag, this should pass.

Slack me if you want some help with the rebase

@Lnaden
Copy link
Copy Markdown
Collaborator

Lnaden commented Apr 28, 2020

Ping @Binikarki for follow up?

@Binikarki
Copy link
Copy Markdown
Contributor Author

@Lnaden I corrected the pbdid to be unpublished_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants