Skip to content

INTPYTHON-617 - Improve DictField to_python performance #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

INTPYTHON-617 - Improve DictField to_python performance #2888

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2931801
WIP
NoahStapp Jun 23, 2025
d4619bd
INTPYTHON-617 - Improve DictField to_python performance
NoahStapp Jun 24, 2025
40aa9a5
Cleanup
NoahStapp Jun 24, 2025
e377528
Refresh CI
NoahStapp Aug 19, 2025
2586d45
Refresh CI
NoahStapp Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mongoengine/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,14 @@ def prepare_query_value(self, op, value):

return super().prepare_query_value(op, value)

def to_python(self, value):
to_python = getattr(self.field, "to_python", None)
return (
{k: to_python(v) for k, v in value.items()}
if to_python and value
else value or None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would convert a {} to None

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

class MyModel(db.Document):
    data_dict_1 = db.DictField(required=False)

m = MyModel()
m.data_dict_1 = {}
m.save()

model = MyModel.objects.first()
print(model.data_dict_1)

Outputs {}.

)


class MapField(DictField):
"""A field that maps a name to a specified field type. Similar to
Expand Down
Loading