[Addition] Character and role selection modes#10977
Open
Sorenon wants to merge 17 commits intoMonkestation:masterfrom
Open
[Addition] Character and role selection modes#10977Sorenon wants to merge 17 commits intoMonkestation:masterfrom
Sorenon wants to merge 17 commits intoMonkestation:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Mode: Simple
You have one set of job priorities. Only one character can be enabled at a time.1. Set job priorities in Overall Occupations
2. Pick one enabled character
Screenshots
Mode: Character Filters
You have one set of job priorities. Multiple characters can be enabled at a time and each character can have different jobs enabled or disabled. When you join the round the game will pick a job for you (or take your chosen job if latejoining) then pick an enabled character which has that job enabled. If the game cannot find one it will pick your default character.1. Set job priorities in Overall Occupations
2. Set job filters in Character Occupations
3. Pick 0 or more enabled characters
4. Pick one default character
Screenshots
Mode: Per Character Priorities (legacy mode)
Each character has their own set of job priorities. Only one character can be enabled at a time.1. Set job priorities in Character Occupations
2. Pick one enabled character
Screenshots
Why It's Good For The Game
Currently if a player wants to restrict their characters to specific jobs they have to limit which jobs they ready up as or latejoin.
The Character Filters mode allows players to leave this up to the server, so before each round they only have to decide how much they want to play each job, and which characters they'd like to play as.
Since antag preferences are actually independent of the selected character, now that all the settings menus have been combined it makes sense to remove it from the character settings.
Testing
Each mode has been tested in both readying up and latejoining.
The new settings save and load correctly.
Changelog
🆑
add: Added three different modes to job selection (Simple, Character Filters, Per Character Priorities)
qol: Moved antag preferences out of character settings since they don't depend on the selected character
/:cl:
Pre-Merge Checklist