Clean up shaving/throatslitting and bodypart butchery code#4450
Closed
noelle-lavenza wants to merge 3 commits intoMonkestation:mainfrom
Closed
Clean up shaving/throatslitting and bodypart butchery code#4450noelle-lavenza wants to merge 3 commits intoMonkestation:mainfrom
noelle-lavenza wants to merge 3 commits intoMonkestation:mainfrom
Conversation
Collaborator
|
open if finish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates shaving, throatslitting, and bodypart butchery into their own procs outside of
MiddleClickto make stuff easier to read and reduce the overall indentation level.Introduces an
is_short_blade(item)helper that checks if an item is a sharp and short weapon, and uses that instead of the bespoke check in a few places.Rewrites bodypart butchery code to be cleaner and separate out a few constants. I originally did a lot more but decided that was overengineered.
untested