Improve code duplication in patron checks#4543
Closed
noelle-lavenza wants to merge 1 commit intoMonkestation:mainfrom
Closed
Improve code duplication in patron checks#4543noelle-lavenza wants to merge 1 commit intoMonkestation:mainfrom
noelle-lavenza wants to merge 1 commit intoMonkestation:mainfrom
Conversation
Collaborator
|
open if finish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creates a
player_humans_by_patronthat gets all humans with clients (e.g. in the player list) with a given patron. this was repeated a lot in event code so i figured i'd make a helper for it. by default it excludes dead mobs.this lets us replace some loops entirely and in others we use it to filter before applying additional checks (like nobility, species, etc).
also makes follower count checks use
GLOB.patron_follower_counts. technically that only updates every two seconds but it should by synchronised with the event stuff so that'll be fiiiiine probably maybeuntested