forked from Darkrp-community/OpenKeep
-
Notifications
You must be signed in to change notification settings - Fork 307
Bomb update #4822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Diegoflores31
wants to merge
4
commits into
Monkestation:main
Choose a base branch
from
Diegoflores31:bombs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bomb update #4822
+114
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2026
Closed
This was referenced Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance
Surely this is good for the game
Code Maintenance
Fixing this mess one line at a time
Fix
This PR is for fixing bugs
Test Merge
Actively test-merged or relating to test merges.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
-This PR changes bombcrafting skill and recipes , introduces a linear path for crafting bombs.
-Removes Bombcrafting from porter and Jester ( he can still get it on RNG only)
-Removes bombcrafting from plague doctor ( he can spawn his own smoke bombs , bombs are the pyromaniacs quirk)
-Adds bombcrafting to Artificer
-Reworks Breaching Charges , they have smoke effects and diferent mining behaviour now.
Why It's Good For The Game
Removes bombcrafting from classes that are not suposed to have it by default. adds it to the ones that should have it by default.( the criteria of it is that bombcrafting is only for classes that are specifically bomb handlers like dwarve adv/merc , jester by rng only because memes and artificer)
Adds a linear path for crafting so you actually need to level it up to get stronger bombs instead of instantly unlocking it.
Changelog
🆑
balance: changes skill requirements of bombcrafting.
balance: removes bombcrafting from: porter , jester and plague doctor.
balance: adds bombcrafting to: artificer
fix: breaching charge now can be used properly to mine.
refactor: breaching charges now use timers instead of process , reworked the logic for cinematic effect.
fix: minimun_skill_required now actually means minimun skill required.
/:cl:
Pre-Merge Checklist