Item Interactions

[CheffieGithub]

About The Pull Request

ABOUT

This pr is going to replace attackby item interactions with real ones based on MrMelbert's work tgstation/tgstation#79968 tgstation/tgstation#83818

Item interactions will take place after tool interactions (which we have none of) and before regular attacks.

SURGERY

I changed a bit about surgeries because they were so awful I had to. (and because their start was moved to an interaction)

Surgeries are started via the same way but now require you to not be in combat mode and be on weak intent.

A surgery can be ended with right click and an empty hand. But it won't fix their wounds from it, obviously.

Surgeries refactored to use surgeries instead of pulling the steps from nothing.

Surgeries no longer require you to embed your tools into the patients limbs, I like it but it causes problems:

• Making all surgeries slower.
• Causing extra damage.
• Getting left inside by mistake (the best).
• Needing to be seperately tracked.

The last point makes more complex surgeries much harder to make.

CPR is no longer a surgery.

External organ severing requires you to incise first.

Heal wounds won't heal extra damage for types it doesn't heal (mend burns won't heal brute)
Heal wounds won't deal damage for types it doesn't heal on failure (mend burns won't deal brute)

Intentional surgery failure is done by right click, I would like to involve item intents as little as possible in most interactions.

Having not enough skill for surgery just simply forces you to fail, so you can still get experience and be malicious.

todo

• Actually remake the sever I deleted it by mistake.
• Add exp gain.
• Test if the item starting surgery can be used for the first step before opening the interface to choose surgery.

INTERACTION CHANGES

Eating food no longer requires use of the FEED intent.

You can force feed food to others.

Syringes inject on left click and draw on right click.

todo for non attack interactions

• attack
• attackby (obvious ones)
• attack_atom (all)
• afterattack (most)
• preattack (most)

Why It's Good For The Game

Allows atom storage to be better, will cleanup afterattack, preattack, attackby misuse and attack chain precedence.

Changelog

🆑
refactor: Refactored attack chain code, report any issues with clicking on things with other things.
refactor: Refactored surgery code, report any cases of surgery issues, you can use an empty hand right click on the patient to cancel the current surgery on the targeted place.
add: Some interactions have been changed that will not be listed here, check the PR page before reporting things.
/:cl:

Pre-Merge Checklist

• You tested this on a local server.
• This code did not runtime during testing.
• You documented all of your changes.

[Blacklist897]

if you are removing tool embeds, replace the spare forceps in surgical bags with something else

[CheffieGithub]

With air so you can have some space

[Gatsby229]

Ok, so number one
surgery is suffering now, being EXPONENTIALLY SLOWER and impossible to actually fix people in time even with master med
number 2
it breaks easily, with some thigns jsut getting ignored and such
number 3
Navigating the surgery options is annoying if you want to do ANYTHING small, because you just get flashed with abunch of options when all you want to do is make an a incision or something