More parlio tweaks

Author: ewowi

docs/moonbase/inputoutput.md

@@ -69,16 +69,15 @@ For each board the following presets are defined:
 
 ### MyHome-Control ESP32-P4 shield
 
-* Choose the esp32-p4-nano board in the [MoonLight Installer](../../gettingstarted/installer/) 
-* On new boards, the WiFi coprocessor needs to be updated first to a recent version, currently v2.0.17, see the link in the [MoonLight Installer](../../gettingstarted/installer/)
-* After install, select the **MHC P4 Nano Shield** board preset to have the pins assigned correctly.
-  * Assuming 100W LED power; change if needed.
-  * Jumper1: off (default): 16 LED pins. On: 8 LED pins, 4 RS-485 pins and 4 exposed pins (set also the switches on the board).
-* Add the Parallel LED Driver, see [Drivers](../../moonlight/drivers/). It uses @troyhacks his parallel IO driver to drive all LED pins configured for the shield.
-
 ![ESP32-P4 shield](https://shop.myhome-control.de/thumbnail/87/41/c2/1762031307/WLED_ESP32_P4_Shield_02_1920x1326.jpg?ts=1762031315){: style="width:320px"}
 
-[ESP32-P4 shield](https://shop.myhome-control.de/en/ABC-WLED-ESP32-P4-shield/HW10027)
+* See [ESP32-P4 shield](https://shop.myhome-control.de/en/ABC-WLED-ESP32-P4-shield/HW10027). Choose the esp32-p4-nano board in the [MoonLight Installer](../../gettingstarted/installer/) 
+* On new ESP32-P4 Nano boards, the WiFi coprocessor needs to be updated first to a recent version, currently ESP-Hosted v2.0.17, see the link in the [MoonLight Installer](../../gettingstarted/installer/)
+* After install, select the **MHC P4 Nano Shield** board preset to have the pins assigned correctly.
+    * Assuming 100W LED power; change if needed.
+    * Jumper1: off (default): 16 LED pins. On: 8 LED pins, 4 RS-485 pins and 4 exposed pins (set also the switches on the board).
+* Add the Parallel LED Driver, see [Drivers](../../moonlight/drivers/). It uses [@troyhacks](https://github.com/troyhacks) his parallel IO driver to drive all LED pins configured for the shield.
+
 
 ### SE16 v1
 

docs/moonlight/drivers.md

@@ -46,7 +46,7 @@ Want to add a Driver to MoonLight, see [develop](../../develop/overview/). See a
 
 ### Light Preset
 
-* **Max Power**: 🆕 moved to [IO Module](../../moonbase/inputoutput/) board presets.
+* **Max Power**: 🆕 moved to [IO Module](../../moonbase/inputoutput) board presets.
 
 * **Light preset**: Defines the channels per light and color order
 
@@ -82,7 +82,7 @@ Receives Art-Net data from the network.
 !!! tip "Other setup"
     * Add a Layout driver to specifify the fixture you are displaying on, e.g. Single Line for Tubes or Panel for Matrices
     * Add the Parallel LED Driver to enable connected LEDs
-    * Go to the [IO Module](../../moonbase/inputoutput/) to define a board preset.
+    * Go to the [IO Module](../../moonbase/inputoutput) to define a board preset.
 
 !!! tip "Running effects and Art-Net In"
     Effects can run at the same time, disable or delete them if you only want to run Art-Net In.

src/MoonLight/Nodes/Drivers/D_ParallelLEDDriver.h

@@ -45,7 +45,7 @@ class ParallelLEDDriver : public DriverNode {
   #endif
   }
 
-  uint8_t pins[MAX_PINS];
+  uint8_t pins[MAX_PINS] = {};
 
   void loop() override {
   #if HP_ALL_DRIVERS

src/MoonLight/Nodes/Drivers/parlio.cpp

@@ -201,6 +201,8 @@ void create_transposed_led_output_optimized(const uint8_t* input_buffer, uint16_
   for (uint32_t pixel_in_pin = 0; pixel_in_pin < pixels_per_pin; ++pixel_in_pin) {
     for (uint32_t component_in_pixel = 0; component_in_pixel < COMPONENTS_PER_PIXEL; ++component_in_pixel) {
       const uint32_t input_component = component_map[component_in_pixel];
+      //component_in_pixel is always RGB(W) - looping over the input array
+      //input_component is offsetR,G,B e.g. GRB -> 102, so this loop starts with 1 / green, so green is first processed, then red, then blue
 
       uint32_t transposed_slices[32];
 
@@ -420,15 +422,15 @@ uint8_t IRAM_ATTR __attribute__((hot)) show_parlio(uint8_t* parallelPins, uint32
   chunk_ptrs[3] = chunk_ptrs[2] + chunk_stride_bytes;
 
   unsigned long before = micros();
-  ESP_ERROR_CHECK(parlio_tx_unit_wait_all_done(parlio_tx_unit, -1));
+  ESP_ERROR_CHECK(parlio_tx_unit_wait_all_done(parlio_tx_unit, portMAX_DELAY));
   unsigned long after = micros();
 
   #ifdef WLEDMM_REMAP_AT_OUTPUT
   parallel_buffer_remapped = (parallel_buffer_remapped == parallel_buffer_remapped1) ? parallel_buffer_remapped2 : parallel_buffer_remapped1;
   #endif
   parallel_buffer_repacked = (parallel_buffer_repacked == parallel_buffer_repacked1) ? parallel_buffer_repacked2 : parallel_buffer_repacked1;
 
-  // if (after - before < 50) delayMicroseconds(20);
+  if (after - before < 50) delayMicroseconds(20);
 
   // portENTER_CRITICAL(&parlio_spinlock);
   for (int i = 0; i < num_chunks && i < 4; ++i) {