pre 71 fixes #107
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "name": "MoonLight on esp32-d0-pico2", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "version": "0.7.0", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "home_assistant_domain": "esphome", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "funding_url": "https://esphome.io/guides/supporters.html", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "new_install_prompt_erase": true, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "new_install_immediately": false, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "builds": [ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "chipFamily": "ESP32", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "name": "esp32-d0", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "image": "./images/esp32-d0-pico2.jpg", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "parts": [ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { "path": "./MoonLight_esp32-d0-pico2_0-7-0_webflash.bin", "offset": 0 } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+1
to
+17
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: # Check platformio.ini for APP_VERSION
find . -name "platformio.ini" -type f | head -5Repository: MoonModules/MoonLight Length of output: 81 🏁 Script executed: # Look for webflash filename patterns in build scripts
rg -n "webflash|MoonLight.*0-7" --type-list | head -20Repository: MoonModules/MoonLight Length of output: 454 🏁 Script executed: # List all manifest files to see the pattern
find . -name "manifest*.json" -type fRepository: MoonModules/MoonLight Length of output: 809 🏁 Script executed: # Check the actual platformio.ini content
cat platformio.ini 2>/dev/null || echo "Not found at root"Repository: MoonModules/MoonLight Length of output: 15082 🏁 Script executed: # Find and read the rename_fw.py script
find . -name "rename_fw.py" -type fRepository: MoonModules/MoonLight Length of output: 87 🏁 Script executed: # Check the rename_fw.py script to understand binary naming
cat scripts/rename_fw.py 2>/dev/null || echo "Not found"Repository: MoonModules/MoonLight Length of output: 2925 🏁 Script executed: # Check another manifest file to see if versions match
cat firmware/installer/manifest_esp32-d0.json | head -20Repository: MoonModules/MoonLight Length of output: 522 🏁 Script executed: # Check a few manifest files for version patterns
for file in ./firmware/installer/manifest_esp32-d0.json ./firmware/installer/manifest_esp32-c3.json; do
echo "=== $file ==="
head -5 "$file"
doneRepository: MoonModules/MoonLight Length of output: 486 Version mismatch: manifest shows 0.7.0 but platformio.ini defines 0.7.1. The manifest version and binary filename must match the Proposed fix {
"name": "MoonLight on esp32-d0-pico2",
- "version": "0.7.0",
+ "version": "0.7.1",
"home_assistant_domain": "esphome",
"funding_url": "https://esphome.io/guides/supporters.html",
"new_install_prompt_erase": true,
"new_install_immediately": false,
"builds": [
{
"chipFamily": "ESP32",
"name": "esp32-d0",
"image": "./images/esp32-d0-pico2.jpg",
"parts": [
- { "path": "./MoonLight_esp32-d0-pico2_0-7-0_webflash.bin", "offset": 0 }
+ { "path": "./MoonLight_esp32-d0-pico2_0-7-1_webflash.bin", "offset": 0 }
]
}
]
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix table pipe style (trailing pipe).
Markdownlint flags this row for trailing pipe usage; align with the project’s
leading_onlystyle.📝 Proposed fix
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
25-25: Table pipe style
Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe
(MD055, table-pipe-style)
🤖 Prompt for AI Agents