rename UI components #75

ewowi · 2025-12-16T09:09:32Z

Summary by CodeRabbit

Documentation
- Updated component docs with new, consistent terminology (Renderer/Widget) and improved examples.
- File Manager and module docs reflect renamed widgets and refined text.
New Features
- Added EditRowWidget and FileEditWidget for row editing and file editing in-place.
Refactor
- Standardized component names and modernized internal iterations for better maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Front-end ======== - MultiInput to FieldRenderer - Array / MultiRow to RowRenderer - FileEdit to FileEditWidget - EditObject to EditRowWidget Back-End ======== - App_DATE: YYYYMMDD - ModuleIO: gpio: ledPins - Nodes: use header

coderabbitai · 2025-12-16T09:09:50Z

Note

`.coderabbit.yaml` has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'review', 'context'

⚙️ Configuration instructions

Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

This pull request renames UI components (MultiInput→FieldRenderer, Array→RowRenderer, FileEdit→FileEditWidget), updates their imports/usages and docs, substitutes component instances across Svelte files, refactors PinAssigner::assignPin parameter and loop iteration in ModuleIO.h, and simplifies nested member access in Nodes.cpp; also updates a build date flag.

Changes

Cohort / File(s)	Summary
Documentation Updates `docs/components.md`, `docs/develop/modules.md`, `docs/moonbase/filemanager.md`, `docs/moonbase/inputoutput.md`, `src/MoonBase/Modules/FileManager.h`	Updated docs and comments to reflect renames: MultiInput→FieldRenderer, Array→RowRenderer, FileEdit→FileEditWidget; minor text refinements and anchor/link updates.
Svelte component files `interface/src/lib/components/moonbase/FieldRenderer.svelte`, `interface/src/lib/components/moonbase/FileEditWidget.svelte`, `interface/src/lib/components/moonbase/RowRenderer.svelte`, `interface/src/lib/components/moonbase/EditRowWidget.svelte`	Replaced imports/usages of old components with their renamed counterparts (FieldRenderer, RowRenderer, FileEditWidget, EditRowWidget); updated header comments and a runtime log string.
Route / Page updates `interface/src/routes/moonbase/filemanager/FileManager.svelte`, `interface/src/routes/moonbase/module/Module.svelte`	Updated imports and template usages to the new component names (FieldRenderer, RowRenderer, FileEditWidget) while preserving props/bindings.
Backend pin management refactor `src/MoonBase/Modules/ModuleIO.h`	Renamed PinAssigner::assignPin parameter (pinNr→gpio_num) and converted index-based loops over pin arrays to range-based iteration across many board configurations.
Node internals refactor `src/MoonBase/Nodes.cpp`	Replaced repeated deep member access with a local `LightsHeader* header` pointer and adjusted reads/writes to use this local reference for color correction, presets, and offsets.
Driver comment tweak `src/MoonLight/Nodes/Drivers/D_FastLED.h`	Minor comment update in a switch-case to reference `ledPins[pinIndex]` instead of `pinNr`.
Build metadata `platformio.ini`	Updated APP_DATE build flag from `"2025121511"` to `"20251216"`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Areas requiring extra attention:
- src/MoonBase/Modules/ModuleIO.h: confirm all callers and call sites compile after assignPin parameter rename and that range-based loops preserve semantics across board configurations.
- interface/... Svelte files: ensure no stale imports/usages remain and that event/prop bindings are intact after component substitutions.
- src/MoonBase/Nodes.cpp: validate the local LightsHeader* usage preserves intended behavior and side effects.

Possibly related PRs

Module: support button, new rows, nested tables #1 — touches MultiInput/Array UI components; likely related to the component rename/substitution work.
Board preset add presets #70 — overlaps changes to ModuleIO pin assignment signature and pin loop traversal; directly related.
Board presets p4 #74 — modifies MultiInput-related UI components; related to the renaming/refactor of UI components.

Suggested labels

enhancement

Poem

🐰 Renamed the fields with a hop and a twitch,
FieldRenderer, RowRenderer, a clean little switch.
FileEditWidget popped into view,
Pins now iterate fresh and true,
I nibble docs and code—what a delicious fix!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Title check	❓ Inconclusive	The title 'rename UI components' is vague and generic. It uses non-descriptive terminology that doesn't convey specific information about which components are renamed or what the new names are.	Consider a more specific title like 'Rename UI components: MultiInput→FieldRenderer, MultiRow→RowRenderer, FileEdit→FileEditWidget, EditObject→EditRowWidget' to clearly communicate the scope of changes.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ui-rendering

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

docs/moonbase/inputoutput.md (1)

78-78: LGTM - Minor grammatical improvement.

The textual refinement from "set also" to "also set" improves readability.

Optional: Consider fixing markdown indentation.

The static analysis tool flagged that this line has incorrect indentation (4 spaces instead of the expected 2 for nested list items). While this doesn't affect functionality, fixing it would improve markdown consistency.
docs/components.md (1)
170-174: Adjust list indentation for consistency.

The nested list items use 4-space indentation instead of the expected 2-space indentation, which is flagged by markdownlint.

Apply this diff to fix the indentation:
 * Show multiple rows of objects
-    * Summary and zoom
+  * Summary and zoom
 * Recursive
-    * A row renderer can have a row renderer e.g. multiple nodes with multiple controls per node
+  * A row renderer can have a row renderer e.g. multiple nodes with multiple controls per node
 * Uses FieldRenderer
src/MoonBase/Modules/ModuleIO.h (1)
478-479: Refactor this loop for consistency.

This loop uses sizeof(ethernetPins) instead of a range-based for loop like the other refactored loops in this PR. While it happens to work (6 bytes for 6 uint8_t elements), it's:

Type-dependent and would break if the array type changed

Inconsistent with the modernized loops throughout this file

Apply this diff to align with the other loop refactorings:
-uint8_t ethernetPins[6] = {28, 29, 30, 31, 34, 35};
-for (int i = 0; i < sizeof(ethernetPins); i++) pinAssigner.assignPin(ethernetPins[i], pin_Ethernet);
+uint8_t ethernetPins[] = {28, 29, 30, 31, 34, 35};
+for (uint8_t gpio : ethernetPins) pinAssigner.assignPin(gpio, pin_Ethernet);

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5558af and 48b7c7f.

📒 Files selected for processing (15)

docs/components.md (1 hunks)
docs/develop/modules.md (1 hunks)
docs/moonbase/filemanager.md (1 hunks)
docs/moonbase/inputoutput.md (1 hunks)
interface/src/lib/components/moonbase/EditRowWidget.svelte (2 hunks)
interface/src/lib/components/moonbase/FieldRenderer.svelte (4 hunks)
interface/src/lib/components/moonbase/FileEditWidget.svelte (4 hunks)
interface/src/lib/components/moonbase/RowRenderer.svelte (5 hunks)
interface/src/routes/moonbase/filemanager/FileManager.svelte (3 hunks)
interface/src/routes/moonbase/module/Module.svelte (2 hunks)
platformio.ini (1 hunks)
src/MoonBase/Modules/FileManager.h (1 hunks)
src/MoonBase/Modules/ModuleIO.h (10 hunks)
src/MoonBase/Nodes.cpp (4 hunks)
src/MoonLight/Nodes/Drivers/D_FastLED.h (1 hunks)

🧰 Additional context used

🧠 Learnings (7)