Skip to content

moving pin high and low out of the define, handling low level rs485 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewowi merged 8 commits into from
Jan 2, 2026
Merged

moving pin high and low out of the define, handling low level rs485 #91

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
de240e2
moving pin high and low out of the define, handling rs485 low level
limpkin Jan 1, 2026
cc997ea
actual humidity and temperature parsing
limpkin Jan 1, 2026
17e92f7
addressing review comments
limpkin Jan 1, 2026
a383081
var reinit, lightcrafter16 layout
limpkin Jan 2, 2026
b8ffb63
addressing pr comments
limpkin Jan 2, 2026
8455ddf
nitpicks
limpkin Jan 2, 2026
0c70342
LightCrafter16 coordinate system explanation
limpkin Jan 2, 2026
f9dc619
yet another nitpick
limpkin Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 68 additions & 5 deletions src/MoonBase/Modules/ModuleIO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#if FT_MOONBASE == 1

#include "MoonBase/Module.h"
#include "driver/uart.h"

enum IO_PinUsageEnum {
pin_Unused, // 0
Expand Down Expand Up @@ -316,8 +317,8 @@ class ModuleIO : public Module {
pinAssigner.assignPin(3, pin_High); // WIZ850_nRST, needs to be high to access RS485_DE, VBUS_DET, WIZ580_nINT. Also drives an LED.
gpio_set_direction((gpio_num_t)3, GPIO_MODE_OUTPUT); // LEAVE here: guarantees the pin is set to high at platform boot so the ethernet module can initialize correctly
gpio_set_level((gpio_num_t)3, 1); // LEAVE here: guarantees the pin is set to high at platform boot so the ethernet module can initialize correctly
pinAssigner.assignPin(17, pin_Serial_TX);
pinAssigner.assignPin(18, pin_Serial_RX);
pinAssigner.assignPin(17, pin_RS485_TX);
pinAssigner.assignPin(18, pin_RS485_RX);
pinAssigner.assignPin(46, pin_RS485_DE);
pinAssigner.assignPin(0, pin_Dig_Input); // Native USB port vbus detection
pinAssigner.assignPin(5, pin_Voltage); // Input voltage
Expand Down Expand Up @@ -602,6 +603,10 @@ class ModuleIO : public Module {
}
}

uint8_t pinRS485TX = UINT8_MAX;
uint8_t pinRS485RX = UINT8_MAX;
uint8_t pinRS485DE = UINT8_MAX;

void readPins() {
#if FT_ENABLED(FT_ETHERNET)
EXT_LOGD(MB_TAG, "Try to configure ethernet");
Expand Down Expand Up @@ -664,7 +669,15 @@ class ModuleIO : public Module {
} else if (usage == pin_Battery) {
pinBattery = pinObject["GPIO"];
EXT_LOGD(ML_TAG, "pinBattery found %d", pinBattery);
} else if (usage == pin_High) {
}
}
#endif

// GPIOs & RS485
bool rs485_ios_updated = false;
for (JsonObject pinObject : _state.data["pins"].as<JsonArray>()) {
uint8_t usage = pinObject["usage"];
if (usage == pin_High) {
uint8_t pinHigh = pinObject["GPIO"];
if (GPIO_IS_VALID_OUTPUT_GPIO(pinHigh)) {
gpio_set_direction((gpio_num_t)pinHigh, GPIO_MODE_OUTPUT);
Expand All @@ -678,9 +691,59 @@ class ModuleIO : public Module {
gpio_set_level((gpio_num_t)pinLow, 0);
}
EXT_LOGD(ML_TAG, "Setting pin %d to low", pinLow);
}
} else if (usage == pin_RS485_DE) {
rs485_ios_updated = true;
pinRS485DE = pinObject["GPIO"];
} else if (usage == pin_RS485_RX) {
rs485_ios_updated = true;
pinRS485RX = pinObject["GPIO"];
} else if (usage == pin_RS485_TX) {
rs485_ios_updated = true;
pinRS485TX = pinObject["GPIO"];
}
}

// Check if all RS485 pins are specified
if (rs485_ios_updated && (pinRS485TX != UINT8_MAX) && (pinRS485RX != UINT8_MAX) && (pinRS485DE != UINT8_MAX)) {
EXT_LOGD(ML_TAG, "RS485 init with pins %d %d %d", pinRS485TX, pinRS485RX, pinRS485DE);

// test code to be replaced with functional code. use UART1 as UART0 is (AFAIK) always for debug serial
uart_config_t uart_config = {
.baud_rate = 9600,
.data_bits = UART_DATA_8_BITS,
.parity = UART_PARITY_DISABLE,
.stop_bits = UART_STOP_BITS_1,
.flow_ctrl = UART_HW_FLOWCTRL_DISABLE, // Flow control handled by RS485 driver
.source_clk = UART_SCLK_DEFAULT,
};
ESP_ERROR_CHECK(uart_driver_install(UART_NUM_1, 128 * 2, 0, 0, NULL, 0));
ESP_ERROR_CHECK(uart_param_config(UART_NUM_1, &uart_config));
ESP_ERROR_CHECK(uart_set_pin(UART_NUM_1, pinRS485TX, pinRS485RX, pinRS485DE, UART_PIN_NO_CHANGE));
ESP_ERROR_CHECK(uart_set_mode(UART_NUM_1, UART_MODE_RS485_HALF_DUPLEX));

#ifdef DEMOCODE_FOR_SHT30_SENSOR
// Modbus RTU Request: [Addr][Func][RegHi][RegLo][CountHi][CountLo][CRC_L][CRC_H]
// To read Reg 0 & 1 from Slave 0x01: 01 03 00 00 00 02 C4 0B
const uint8_t request[] = {0x01, 0x03, 0x00, 0x00, 0x00, 0x02, 0xC4, 0x0B};
uint8_t response[128];
// Send request
uart_write_bytes(UART_NUM_1, (const char*)request, sizeof(request));
ESP_LOGI(ML_TAG, "Request sent");

// Wait for response (timeout 1 second)
int len = uart_read_bytes(UART_NUM_1, response, 128, pdMS_TO_TICKS(100));

if (len > 0) {
ESP_LOGI(ML_TAG, "Answer recceived: %d %d %d %d %d %d %d %d %d", response[0], response[1], response[2], response[3], response[4], response[5], response[6], response[7], response[8]);
Copy link

@coderabbitai coderabbitai bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor: Typo and inconsistent logging macros.

  • Line 731, 737, 740, 743: Uses ESP_LOGI/ESP_LOGW while the rest of the file uses EXT_LOGD/EXT_LOGV.
  • Line 737: Typo "recceived" → "received".
🔎 Proposed fix 
       uart_write_bytes(UART_NUM_1, (const char*)request, sizeof(request));
-      ESP_LOGI(ML_TAG, "Request sent");
+      EXT_LOGD(ML_TAG, "Request sent");
 
       // Wait for response (timeout 1 second)
       int len = uart_read_bytes(UART_NUM_1, response, 128, pdMS_TO_TICKS(100));
       
       if (len > 0) {
-          ESP_LOGI(ML_TAG, "Answer recceived: %d %d %d %d %d %d %d %d %d", response[0], response[1], response[2], response[3], response[4], response[5], response[6], response[7], response[8]);
+          EXT_LOGD(ML_TAG, "Answer received: %d %d %d %d %d %d %d %d %d", response[0], response[1], response[2], response[3], response[4], response[5], response[6], response[7], response[8]);
           float humidity = ((float)response[3])*256 + (float)response[4];
           float temperature = ((float)response[5])*256 +(float)response[6];
-          ESP_LOGI(ML_TAG, "humidity: %f temperature: %f", humidity/10, temperature/10);
+          EXT_LOGD(ML_TAG, "humidity: %f temperature: %f", humidity/10, temperature/10);
           // Process registers here (response[3] to response[6] contain the data)
       } else {
-          ESP_LOGW(ML_TAG, "No response from sensor");
+          EXT_LOGW(ML_TAG, "No response from sensor");
       }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ESP_LOGI(ML_TAG, "Request sent");
// Wait for response (timeout 1 second)
int len = uart_read_bytes(UART_NUM_1, response, 128, pdMS_TO_TICKS(100));
if (len > 0) {
ESP_LOGI(ML_TAG, "Answer recceived: %d %d %d %d %d %d %d %d %d", response[0], response[1], response[2], response[3], response[4], response[5], response[6], response[7], response[8]);
EXT_LOGD(ML_TAG, "Request sent");
// Wait for response (timeout 1 second)
int len = uart_read_bytes(UART_NUM_1, response, 128, pdMS_TO_TICKS(100));
if (len > 0) {
EXT_LOGD(ML_TAG, "Answer received: %d %d %d %d %d %d %d %d %d", response[0], response[1], response[2], response[3], response[4], response[5], response[6], response[7], response[8]);
float humidity = ((float)response[3])*256 + (float)response[4];
float temperature = ((float)response[5])*256 +(float)response[6];
EXT_LOGD(ML_TAG, "humidity: %f temperature: %f", humidity/10, temperature/10);
// Process registers here (response[3] to response[6] contain the data)
} else {
EXT_LOGW(ML_TAG, "No response from sensor");
}
🤖 Prompt for AI Agents 
In src/MoonBase/Modules/ModuleIO.h around lines 731-737, the logging calls use
ESP_LOGI/ESP_LOGW and contain a typo "recceived"; change those calls to the
file's standard EXT_LOGD/EXT_LOGV variants and correct the message to
"received". Specifically replace the ESP_LOGI that logs "Request sent" and the
response print call with the matching EXT_LOGD/EXT_LOGV macros used elsewhere,
and update the format string text to "Answer received" (keeping the existing
byte-format arguments intact).

float humidity = ((float)response[3])*256 + (float)response[4];
float temperature = ((float)response[5])*256 +(float)response[6];
ESP_LOGI(ML_TAG, "humidity: %f temperature: %f", humidity/10, temperature/10);
// Process registers here (response[3] to response[6] contain the data)
} else {
ESP_LOGW(ML_TAG, "No response from sensor");
}
#endif
}
#endif
}

#if FT_BATTERY
Expand Down