Check return status of pacman for clean #1471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This should probably be checked the same way as elsewhere. An overall ret value that we return at the end of the function. Doing this would mean a non 0 from pacman would stop the AUR clean from running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure if this behavior was to some degree intentional, but it's tripped me up a couple times. Now, when you run
paru -Scand then^C, it fully exits immediately, rather than just the pacman process being cancelled and having to^Cagain the paru process. If it was intentional to not immediately exit on pacman error, maybecleancould just check whether it exited from a signal or not.