Skip to content

draft: Conduit related code clean up and reorganization #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
MagicSweepy wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

draft: Conduit related code clean up and reorganization #2

MagicSweepy wants to merge 18 commits into from

Conversation

@MagicSweepy
Copy link
Member

@MagicSweepy MagicSweepy commented Oct 1, 2025 •
edited
Loading

This PR clean up and reorganized code which related with conduits, used modern syntax in some part, and:

  • Unified some param name, like dir, direction, fromDir, fromDirection, facing.
  • Deleted prefix for interfaces, used Impl name format.
  • Deleted unused Enum prefix.
  • Clean up Javadocs and add some required descriptions.
  • Prepare some contents which should be rework with Morphism Lib contents, used TODO label for these part.

Conduit API Part

  • IConduit and its side-dist class renaming.
  • Clean up ConduitNetwork and ConduitBundle.
  • Clean up ConduitUtil.
  • Clean up facade and geometry part.
  • Clean up ConduitBuilder, ConduitRegistry and its definitions.
  • Clean up conduit diagnostics.
  • Split crazypants.enderio.api.conduits.Readme class to docs.

Game Object Part

  • Clean up conduit probe.
  • Clena up yeta wrench interactions.
  • Clean up conduit items, blocks and tileEntities.

@MagicSweepy MagicSweepy self-assigned this Oct 1, 2025
@MagicSweepy MagicSweepy added type: refactor Rewriting a part of the code to have a nicer code overall, only for PR. type: affects balance Some affects balance for game contents, both for Issue or PR. status: ongoing freeze Not just a bug fix and thus affected by a current freeze for a upcoming version, only for PR. and removed type: affects balance Some affects balance for game contents, both for Issue or PR. labels Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MagicSweepy MagicSweepy

Labels

status: ongoing freeze Not just a bug fix and thus affected by a current freeze for a upcoming version, only for PR. type: refactor Rewriting a part of the code to have a nicer code overall, only for PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MagicSweepy