Make nothing :: Maybe a, remove extra parameter #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nothing` is only used in one place, and as a function it was called incorrectly before: `nothing()` instead of `nothing(undefined)`. This commit fixes that by removing the extra layer of function wrapping entirely, and making `nothing` a constant of type `Maybe a`. This is to avoid the more verbose alternative - adding the `undefined` argument.
Member
|
Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nothingis only used in one place, and as a function it was called incorrectly before:nothing()instead ofnothing(undefined). (See #500 (comment).)This PR fixes that by removing the extra layer of function wrapping entirely, and making
nothinga constant of typeMaybe a. This is to avoid the more verbose alternative — adding theundefinedargument.