feat: update info event kind from 38383 to 38385 #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add infoEventKind constant for new Mostro info event kind - Update subscription filter to include kind 38385 - Change info event detection from z-tag to kind-based filtering
Contributor
WalkthroughThis change introduces support for the Mostro "info" event kind (38385) in the open orders repository. The Nostr filter is extended to request both order and info events, and event detection logic is updated to use event kind comparison instead of type checking. Changes
Possibly related issues
Poem
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AndreaDiazCorreia
pushed a commit
that referenced
this pull request
Jan 20, 2026
- Add infoEventKind constant for new Mostro info event kind - Update subscription filter to include kind 38385 - Change info event detection from z-tag to kind-based filtering
grunch
added a commit
that referenced
this pull request
Jan 21, 2026
…nce (phase 4) (#408) * feat: add notification settings screen with push notification preferences Add NotificationSettingsScreen with support for push notification configuration: - Add route for /notification_settings in app router - Implement UI for push notifications toggle with platform detection - Add notification preferences for sound and vibration settings - Display privacy information card explaining encrypted token approach - Add Settings model fields for pushNotificationsEnabled, notificationSoundEnabled, not * refactor: simplify Switch styling and update MockSettings with notification fields - Replace activeTrackColor and activeThumbColor with single activeColor property in Switch widgets - Add missing notification-related getters to MockSettings (isLoggingEnabled, pushNotificationsEnabled, notificationSoundEnabled, notificationVibrationEnabled) - Update MockSettings copyWith method to include new notification preference parameters * feat: integrate push notification service with session and settings management - Add setPushServices method to SettingsNotifier to connect with PushNotificationService and FCMService - Implement automatic token unregistration when user disables push notifications in settings - Add setPushNotificationService method to SessionNotifier for automatic token registration - Register push tokens automatically when new sessions are saved - Initialize push notification integration in main.dart with settings * Unify brand colors and consolidate color variants, phase 1 (#407) * standardize brand green color across application * replace hardcoded background and utility colors with AppTheme constants * replace remaining harcoded colors * add doc with phases * feat: update info event kind from 38383 to 38385 (#410) - Add infoEventKind constant for new Mostro info event kind - Update subscription filter to include kind 38385 - Change info event detection from z-tag to kind-based filtering * Bump to version 1.0.7 * Update changelog file * docs: update FCM implementation roadmap to reflect current progress and future encryption plans - Update phase descriptions to clarify current unencrypted implementation (Phase 3) vs future encrypted approach (Phase 5) - Mark Phase 4 (user settings and opt-out) as complete - Move encryption implementation details from Phase 3 to new Phase 5 (future work) - Add privacy note explaining current plaintext token registration over HTTPS - Update PushNotificationService to remove encryption code and use --------- Co-authored-by: Catrya <140891948+Catrya@users.noreply.github.com> Co-authored-by: grunch <fjcalderon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispute (kind 38386) and rating (kind 38384) events were not actively used in the app, so no changes were needed for them. The app only subscribed to and processed info events (now migrated to kind 38385).
Summary by CodeRabbit
New Features
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.