fix: display selected fiat amount instead of range for taken orders

[Catrya]

fix #441

Summary by CodeRabbit

• Refactor
  • Consolidated fiat amount display logic in the trade detail screen for improved code maintainability.

[coderabbitai]

Walkthrough

A single-file refactoring that consolidates fiat amount display logic in the trade detail screen. A new helper method _displayFiatAmount() determines whether to display a range (for pending orders with differing min/max amounts) or a single amount, replacing three inline conditional expressions.

Changes

Cohort / File(s)	Summary
Fiat Amount Display Logic lib/features/trades/screens/trade_detail_screen.dart	Added _displayFiatAmount(Order) helper method that returns a min-max range string for pending orders with differing amounts, or the actual fiatAmount otherwise. Consolidated three inline amount-rendering expressions into calls to this helper. Added Order model import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat: display premium/discount in order details and omit 0% #232 — Also modifies trade_detail_screen.dart and changes OrderAmountCard display logic, consolidating how amount values are rendered.
• New range order UX #253 — Implements range-order input and state management (minAmount/maxAmount fields) that this PR's display logic depends on.

Suggested reviewers

• AndreaDiazCorreia
• grunch
• mostronator

Poem

🐰 A range once scattered across the screen,
Now bundled cleanly, clear to be seen!
The fiat amounts, both small and wide,
Now show with grace, side by side. ✨

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing the display of a selected fiat amount instead of a range for taken orders, which directly corresponds to the code refactoring that introduces _displayFiatAmount logic.
Linked Issues check	✅ Passed	The changes directly address issue #441 by introducing _displayFiatAmount method that displays selected fiat amount for non-pending orders and ranges only for pending orders, matching the requirement to show actual selected amount instead of full range for taken orders.
Out of Scope Changes check	✅ Passed	All changes are scoped to the trade detail screen's fiat amount display logic, with only one helper method addition and refactoring of existing display calls, all directly related to issue #441.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-range-displays

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

lib/features/trades/screens/trade_detail_screen.dart (1)

105-116: Remove redundant pending status check; use caller's isPending value instead.

The method re-derives isPending from order.status (line 111), but the caller already determined it from tradeState.status (line 53). Since OrderState encapsulates the authoritative state, using inconsistent sources (checking order.status within the method while tradeState.status drives the caller's logic) risks silent bugs if these fields ever diverge. Pass the already-resolved isPending flag as a parameter:

Suggested fix

-  String _displayFiatAmount(Order order) {
+  String _displayFiatAmount(Order order, {required bool isPending}) {
     final isRangeOrder = order.minAmount != null &&
         order.maxAmount != null &&
         order.minAmount != order.maxAmount;
-    final isPending = order.status == Status.pending;
     if (isRangeOrder && isPending) {
       return "${order.minAmount} - ${order.maxAmount}";
     }
     return order.fiatAmount.toString();
   }

Update call sites to pass the resolved flag:

-          amount: _displayFiatAmount(tradeState.order!),
+          amount: _displayFiatAmount(tradeState.order!, isPending: isPending),

[grunch]

LGTM