Skip to content

Fix #447 - orders with premium are rejected#86

Merged
grunch merged 1 commit intomainfrom
feature-check-on-amount-and-premium
Feb 23, 2025
Merged

Fix #447 - orders with premium are rejected#86
grunch merged 1 commit intomainfrom
feature-check-on-amount-and-premium

Conversation

@arkanoider
Copy link
Collaborator

@grunch @Catrya

with these PR now we have:

pinballwizard@pop-os:~/rust_prj/testMostroCli$ ./mostro-cli neworder -k sell -a 6000  -c usd -f 5 -m sepa -p 1

Result:

INFO mostrod::util: Sending DM, Event ID: eb0b02d44b361396ea142f0798cb582343018804775d6bc043c90da9c8ce789e with payload: "{\"cant-do\":{\"version\":1,\"request_id\":11685684561320541688,\"trade_index\":null,\"action\":\"cant-do\",\"payload\":{\"cant_do\":\"invalid_parameters\"}}}"

While:

pinballwizard@pop-os:~/rust_prj/testMostroCli$ ./mostro-cli neworder -k sell -c usd -f 5 -m sepa -p 1

Publishes correctly the order.

As a bonus and error in CantDo enumerate is added: PendingOrderExists

@arkanoider arkanoider requested a review from grunch February 22, 2025 17:48
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grunch grunch merged commit 1fde9e6 into main Feb 23, 2025
1 check passed
@grunch grunch deleted the feature-check-on-amount-and-premium branch February 23, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants