Makes filter keep focus when hiding/showing sticky#1711
Open
samgrrehder wants to merge 1 commit intoMottie:masterfrom
Open
Makes filter keep focus when hiding/showing sticky#1711samgrrehder wants to merge 1 commit intoMottie:masterfrom
samgrrehder wants to merge 1 commit intoMottie:masterfrom
Conversation
The filter doesn't change the focused element when showing or hiding the sticky header. This fixes it.
Mottie
requested changes
Aug 12, 2020
| if (isVisible !== laststate) { | ||
| // make sure the focused filter stay focused after showing/hiding sticky | ||
| var $td = $(document.activeElement).closest('td'), | ||
| column = $td.parent().children().index($td); |
Owner
There was a problem hiding this comment.
Hi! Thanks for contributing and I'm sorry for taking so long to follow up on this PR!
Would you please change this to get the cell's index from the data-column attribute since the header may have a colspan which would mess up this calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter doesn't update the focused element when showing or hiding the sticky header. This fixes it.