Conversation
…exLm, added tests for writeVertex
Update to develop branch of libminc
…ToVolume test to not fail when minc-stuffs is not installed. All tests now pass (with minc-stuffs not installed).
… fail. Test for matrix equivalence instead (i.e. ignore attributes).
…ng functions (e.g. mincMean) require groupings to be factors. This commit adds a check to groupings, converts to factor if necessary, and throws a warning. This fixes failing tests in R>=4.0.0.
…w adds hidden length arguments when calling BLAS / Lapack functions from C, see https://blog.r-project.org/2019/09/25/gfortran-issues-with-lapack-ii/). This is fixed using the solution described in the Writing R Extensions manual (https://rstudio.github.io/r-manuals/r-exts/The-R-API.html#fortran-character-strings), i.e. invoking the FCONE macro.
Added attributes to the vertexMean and friends to make it compatible with vertexLm
…ith having voxel varying data on the right hand side of the linear model equation) - updated mincArray to allow for masked data
Brian told me to fix this! Blame him not me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jasonlerch @yohanyee
Can we get a new release with develop merged?