Report errors when saving masks to *_seg.npy#1129
Merged
carsen-stringer merged 1 commit intoMouseLand:mainfrom Apr 7, 2025
Merged
Report errors when saving masks to *_seg.npy#1129carsen-stringer merged 1 commit intoMouseLand:mainfrom
carsen-stringer merged 1 commit intoMouseLand:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage 52.69% 52.69%
=======================================
Files 18 18
Lines 4342 4342
=======================================
Hits 2288 2288
Misses 2054 2054 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in the GUI, when saving the masks in a
*_seg.npyfile fails, no error message is printed and the process silently stops in the call tonp.saveingui/io.py, function_save_sets.With this PR, an error message would be displayed, giving hints about the cause of the failure (e.g. ``permission denied''), and the process would go further (e.g. updating the graphical display if needed, which should happen even if the call to
np.savefailed).