Skip to content

Report errors when saving masks to *_seg.npy#1129

Merged
carsen-stringer merged 1 commit intoMouseLand:mainfrom
deroulers:report-save-seg-errors
Apr 7, 2025
Merged

Report errors when saving masks to *_seg.npy#1129
carsen-stringer merged 1 commit intoMouseLand:mainfrom
deroulers:report-save-seg-errors

Conversation

@deroulers
Copy link
Contributor

Currently, in the GUI, when saving the masks in a *_seg.npy file fails, no error message is printed and the process silently stops in the call to np.save in gui/io.py, function _save_sets.

With this PR, an error message would be displayed, giving hints about the cause of the failure (e.g. ``permission denied''), and the process would go further (e.g. updating the graphical display if needed, which should happen even if the call to np.save failed).

@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.69%. Comparing base (4d30972) to head (f976bd1).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   52.69%   52.69%           
=======================================
  Files          18       18           
  Lines        4342     4342           
=======================================
  Hits         2288     2288           
  Misses       2054     2054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carsen-stringer carsen-stringer merged commit 450ecea into MouseLand:main Apr 7, 2025
12 checks passed
@carsen-stringer
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants