Skip to content

3D GUI: compute ortho cell outlines separately#1418

Open
mrariden wants to merge 7 commits intomainfrom
3d_ortho_outline
Open

3D GUI: compute ortho cell outlines separately#1418
mrariden wants to merge 7 commits intomainfrom
3d_ortho_outline

Conversation

@mrariden
Copy link
Copy Markdown
Collaborator

@mrariden mrariden commented Mar 20, 2026

This PR improves the 3D and 2D GUI.

  1. Compute the outlines for cells in orthoviews separately so the outlines look more complete in the 3D GUI. Previously, the outlines were only computed in the XY plane for each Z slice. This produced ortho slices with incomplete outlines in the YZ/XZ views.
  2. Remove unused upsampling code (left over from CP3 upsampling models)
  3. Fix compute_restore() not defined error when loading
  4. Fix filter button and remove filter functionality
  • GUI testing protocol
  • tests passing

fix filter button/remove filter functionality by simplifying filter button to use signals/slots. Also removed 2-way dependency in FilterButton class. Replaced print debug statements with logging debug statements.
…when image already loaded in 3D GUI

- refactor ortho outpix calculation
- add update function where needed
- move crosshair update to before getting locations to fix IndexError on previous image size
@mrariden
Copy link
Copy Markdown
Collaborator Author

Before fixing ortho outlines:

image

After fixing ortho outlines:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant