(extension) allow deleting title mapping [DA-412] by Mr-Quin · Pull Request #333 · Mr-Quin/danmaku-anywhere

Mr-Quin · 2026-03-21T04:40:32Z

Mr-Quin · 2026-03-21T04:40:36Z

Task linked: DA-412 Allow deleting title mapping

gemini-code-assist · 2026-03-21T04:40:56Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience for managing title mappings within the extension by introducing robust deletion capabilities. Users can now easily remove individual title mappings or select multiple mappings for bulk deletion, streamlining the management process. This is achieved through new UI components for multiselection and underlying service and RPC method additions for efficient data handling.

Highlights

Bulk Deletion for Title Mappings: Implemented the ability to delete multiple title mappings simultaneously through a new multiselect UI in the extension settings.
Multiselect UI Integration: Introduced a multiselect mode for lists, allowing users to select multiple items and perform bulk actions, starting with title mappings.
New RPC and Persistence Methods: Added a new RPC method (seasonMapDeleteMany) and a corresponding persistence service method (removeMany) to handle the deletion of multiple title mappings in the background.
Expanded Content Script Scope: Updated the extension's manifest to allow content scripts to run on all URLs (<all_urls>), ensuring broader compatibility.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

cloudflare-workers-and-pages · 2026-03-21T04:41:22Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	danmaku-anywhere-web	`9e50fb7`	Commit Preview URL Branch Preview URL	Mar 21 2026, 04:59 AM

gemini-code-assist

Code Review

This pull request adds the functionality to delete title mappings, both individually and in bulk. The changes span from the backend service and RPC layer to the frontend components. New reusable components like MultiselectChip and SelectionBottomBar have been created, and DraggableList has been enhanced to support multiselect. The implementation is solid. I have a few suggestions to improve the user experience of the "select all" feature and to clean up the translation keys for better maintainability. I also found a missing translation key in the Chinese localization file which could lead to incorrect text being displayed.

packages/danmaku-anywhere/src/common/localization/locales/zh/translation.json

gemini-code-assist · 2026-03-21T04:43:51Z

packages/danmaku-anywhere/src/common/components/TitleMapping/TitleMappingPageCore.tsx

+  const handleSelectAll = () => {
+    if (selectedIds.length > 0) {
+      setSelectedIds([])
+    } else {
+      setSelectedIds(mappings.map((m) => m.key))
+    }
+  }


The "select all" functionality can be made more intuitive. The current implementation deselects all items if any are selected. A more standard UX is:

If some items are selected, the checkbox is in an indeterminate state. Clicking it selects all.

If all items are selected, the checkbox is checked. Clicking it deselects all.

If no items are selected, it's unchecked. Clicking it selects all.

To implement this, you can adjust handleSelectAll and also update the Checkbox component on line 123 to use the checked and indeterminate props correctly, like so:

<Checkbox checked={mappings.length > 0 && selectedIds.length === mappings.length} indeterminate={selectedIds.length > 0 && selectedIds.length < mappings.length} onChange={handleSelectAll} size="small" edge="start" />

Suggested change

const handleSelectAll = () => {

if (selectedIds.length > 0) {

setSelectedIds([])

} else {

setSelectedIds(mappings.map((m) => m.key))

}

}

const handleSelectAll = () => {

if (mappings.length > 0 && selectedIds.length === mappings.length) {

setSelectedIds([])

} else {

setSelectedIds(mappings.map((m) => m.key))

}

}

gemini-code-assist · 2026-03-21T04:43:52Z

packages/danmaku-anywhere/src/common/components/TitleMapping/TitleMappingPageCore.tsx

+  const handleDeleteOne = (key: string) => {
+    dialog.delete({
+      title: t('common.delete', 'Delete'),
+      content: t(
+        'titleMapping.deleteConfirmOne',
+        'Are you sure you want to delete this title mapping?'
+      ),
+      onConfirm: async () => {
+        await mutations.delete.mutateAsync(key)
+      },
+    })
+  }


To improve maintainability and reduce the number of translation strings, you can reuse the existing pluralized translation key titleMapping.deleteConfirm for single item deletion confirmation, instead of using a separate titleMapping.deleteConfirmOne key. You can do this by passing { count: 1 } to the t function. After this change, the deleteConfirmOne key can be removed from the translation files.

Suggested change

const handleDeleteOne = (key: string) => {

dialog.delete({

title: t('common.delete', 'Delete'),

content: t(

'titleMapping.deleteConfirmOne',

'Are you sure you want to delete this title mapping?'

),

onConfirm: async () => {

await mutations.delete.mutateAsync(key)

},

})

}

const handleDeleteOne = (key: string) => {

dialog.delete({

title: t('common.delete', 'Delete'),

content: t(

'titleMapping.deleteConfirm',

'Are you sure you want to delete {{count}} title mapping(s)?',

{ count: 1 }

),

onConfirm: async () => {

await mutations.delete.mutateAsync(key)

},

})

}

packages/danmaku-anywhere/src/common/localization/locales/en/translation.json

packages/danmaku-anywhere/src/common/localization/locales/zh/translation.json

Copilot

Pull request overview

This PR adds UI and backend support for deleting title mappings in the browser extension, including single-item delete actions and multiselect bulk deletion.

Changes:

Add bulk-delete RPC (seasonMapDeleteMany) and background persistence support to remove multiple mappings at once.
Update the Title Mapping UI to support multiselect, single delete actions, and a bottom action bar for bulk deletion.
Refactor multiselect UI into reusable components and broaden the player content-script match pattern.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/danmaku-anywhere/src/content/player/PlayerScript.service.ts	Uses `getRandomUUID()` for safer UUID generation in broader contexts.
packages/danmaku-anywhere/src/common/seasonMap/queries/useAllSeasonMap.ts	Adds `deleteMany` mutation calling the new RPC endpoint.
packages/danmaku-anywhere/src/common/rpcClient/background/types.ts	Extends background RPC contract with `seasonMapDeleteMany`.
packages/danmaku-anywhere/src/common/localization/locales/en/translation.json	Adds delete confirmation strings for single and plural deletion cases.
packages/danmaku-anywhere/src/common/localization/locales/zh/translation.json	Adds delete confirmation strings for single and plural deletion cases.
packages/danmaku-anywhere/src/common/components/TitleMapping/TitleMappingPageCore.tsx	Introduces multiselect state, delete confirmation dialogs, and bulk delete UX.
packages/danmaku-anywhere/src/common/components/TitleMapping/TitleMappingList.tsx	Adds per-row delete action and passes multiselect props into `DraggableList`.
packages/danmaku-anywhere/src/common/components/SelectionBottomBar.tsx	New reusable bottom bar for multiselect actions (cancel + selection count + actions).
packages/danmaku-anywhere/src/common/components/MultiselectChip.tsx	New reusable “Multiselect” toggle chip used by multiple pages.
packages/danmaku-anywhere/src/common/components/DraggableList.tsx	Adds multiselect rendering/selection toggling to the generic list component.
packages/danmaku-anywhere/src/common/components/DanmakuSelector/components/MountPageToolbar.tsx	Reuses `MultiselectChip` instead of inlining the chip UI.
packages/danmaku-anywhere/src/background/services/persistence/TitleMappingService.ts	Adds `removeMany()` to delete multiple mappings in one Dexie query.
packages/danmaku-anywhere/src/background/rpc/RpcManager.ts	Wires new RPC method to `TitleMappingService.removeMany`.
packages/danmaku-anywhere/manifest.ts	Changes player content-script match patterns to `<all_urls>`.
package.json	Adds convenience scripts for extension development.

Comments suppressed due to low confidence (1)

packages/danmaku-anywhere/manifest.ts:60

Switching the player content script match patterns from https://*/* + http://*/* to <all_urls> is a significant scope expansion (e.g., includes file:// and ftp://). If the intent is only to support additional specific schemes (like file://), consider explicitly listing only the required schemes/patterns to minimize permission/surface area, and verify the declared host_permissions remain aligned with the matches patterns.

    {
      matches: ['<all_urls>'],
      js: ['src/content/player/index.ts'],
      run_at: 'document_start',
      all_frames: true,
      // isolated world by default

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-21T04:45:20Z

packages/danmaku-anywhere/src/common/components/TitleMapping/TitleMappingPageCore.tsx

+              <Checkbox
+                checked={selectedIds.length > 0}
+                onChange={handleSelectAll}
+                size="small"
+                edge="start"
+              />


The “select all” checkbox is currently driven by selectedIds.length > 0 and handleSelectAll clears the selection whenever any items are selected. This makes it impossible to go from a partial selection to “all selected”, and the checkbox can’t represent a partial (indeterminate) state. Consider setting checked only when selectedIds.length === mappings.length (and mappings.length > 0), using indeterminate when 0 < selectedIds.length < mappings.length, and updating handleSelectAll to select all unless everything is already selected.

Copilot · 2026-03-21T04:45:20Z

packages/danmaku-anywhere/src/common/components/TitleMapping/TitleMappingPageCore.tsx

+  const handleSelectAll = () => {
+    if (selectedIds.length > 0) {
+      setSelectedIds([])
+    } else {
+      setSelectedIds(mappings.map((m) => m.key))
+    }


handleSelectAll currently toggles based on selectedIds.length > 0, which means if the user has a partial selection it will clear instead of selecting all. Consider toggling based on whether all items are already selected (e.g., compare against mappings.length) so the control behaves like a true “select all / clear all”.

packages/danmaku-anywhere/src/common/components/TitleMapping/TitleMappingList.tsx

packages/danmaku-anywhere/src/common/components/DraggableList.tsx

Mr-Quin self-assigned this Mar 21, 2026

Copilot AI review requested due to automatic review settings March 21, 2026 04:40

Copilot started reviewing on behalf of Mr-Quin March 21, 2026 04:41 View session

gemini-code-assist bot reviewed Mar 21, 2026

View reviewed changes

Copilot AI reviewed Mar 21, 2026

View reviewed changes

Mr-Quin force-pushed the DA-412_Allow-deleting-title-mapping branch from 53b9836 to 911ec1f Compare March 21, 2026 04:54

Mr-Quin added 2 commits March 20, 2026 21:57

sad

caad313

ggs

9e50fb7

Mr-Quin force-pushed the DA-412_Allow-deleting-title-mapping branch from 911ec1f to 9e50fb7 Compare March 21, 2026 04:57

Mr-Quin merged commit 6738e94 into master Mar 21, 2026
12 checks passed

Mr-Quin deleted the DA-412_Allow-deleting-title-mapping branch March 21, 2026 05:04

Mr-Quin added the preview release Create a preview release label Mar 21, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(extension) allow deleting title mapping [DA-412]#333

(extension) allow deleting title mapping [DA-412]#333
Mr-Quin merged 2 commits intomasterfrom
DA-412_Allow-deleting-title-mapping

Mr-Quin commented Mar 21, 2026

Uh oh!

Mr-Quin commented Mar 21, 2026

Uh oh!

gemini-code-assist bot commented Mar 21, 2026

Uh oh!

cloudflare-workers-and-pages bot commented Mar 21, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Mar 21, 2026

Uh oh!

gemini-code-assist bot Mar 21, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Mr-Quin commented Mar 21, 2026

Uh oh!

Mr-Quin commented Mar 21, 2026

Uh oh!

gemini-code-assist bot commented Mar 21, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

cloudflare-workers-and-pages bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cloudflare-workers-and-pages bot commented Mar 21, 2026 •

edited

Loading