Fix trailers friction and make them slowdown gracefully#466
Open
enricotagliavini wants to merge 2 commits intoMrCrayfish:1.16.Xfrom
Open
Fix trailers friction and make them slowdown gracefully#466enricotagliavini wants to merge 2 commits intoMrCrayfish:1.16.Xfrom
enricotagliavini wants to merge 2 commits intoMrCrayfish:1.16.Xfrom
Conversation
Basic logic to stop a trailer when unhitched while moving to prevent infinite motion in last direction. Can implement a nicer slow down logic in a later commit
Implement the same slowdown mechanics as the PoweredVehicle for trailers
Author
|
Oh I'm 19 hours late apparently, I see this might have been fixed already ^_^''' EDIT: or maybe not. The code was changed to the new mappings(?), but I can't see any slowdown logic. Unfortunately I can't test the new code, I get a crash on world load |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fix an issue reported multiple times such as
#450
#448
I tested this change in 1.16.5. I had to use a commit from a few days ago as the very latest from 1.16.X crashes my game and am not sure why as of yet.
Disclaimer: first time ever I try to code on a Minecraft mod, hopefully I've done nothing completely dumb :)