Conversation
- update hugo.yaml to include addObituaryUrl parameter - add "Add an Obituary" button in index.html with link to GitHub issues template 🐛 fix(site): update GitHub edit URL - change editURL in hugo.yaml to point to new repository location
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new “Add an Obituary” submission button to the homepage and updates the site’s GitHub edit URL.
- Introduce
addObituaryUrlparam inhugo.yamland updateeditURLto the new repo - Add an “Add an Obituary” button in
index.htmllinking to the GitHub issues template
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| site/layouts/index.html | Inserted “Add an Obituary” button and merged sort logic with section tag |
| site/hugo.yaml | Updated editURL to point at new repo and added addObituaryUrl param |
Comments suppressed due to low confidence (2)
site/layouts/index.html:12
- Add a UI or integration test to verify that the 'Add an Obituary' button renders correctly and navigates to the configured URL.
<a href="{{ site.Params.addObituaryUrl}}" class="btn btn-secondary mb-3">
site/hugo.yaml:20
- Update the project’s configuration docs to explain the new
addObituaryUrlparameter and how to override it.
addObituaryUrl: "https://github.com/MrHinsh/killed-by-scrumorg/issues/new?template=add-an-obituary.yml"
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-stone-0045b7f10-8.centralus.6.azurestaticapps.net |
- create copilot-instructions.md with guidelines for GitHub Copilot usage - include build commands, project structure, and key features ✨ feat(discussions): automate GitHub discussions creation - add Create-GitHubDiscussions.ps1 script to automate discussion creation - update register.json with discussionId and discussionUrl fields ✨ feat(site): integrate GitHub discussions in site - update index.html to include discussion buttons - add githubRepo parameter in hugo.yaml for configuration
- adjust HTML structure for better readability - ensure consistent spacing and indentation ♻️ refactor(powershell): simplify data file update process - remove backup creation to prevent Hugo conflicts - streamline data saving with proper formatting
- Refine project overview to clarify tracked entities as discontinued initiatives, tools, and programs - Enhance GitHub Discussions integration section with detailed workflow and prerequisites - Update data format and key features with new requirements and functionality - Add technical details and guidelines for contributing and development process 🔧 chore(register.json): remove redundant discussionUrl fields - Simplify JSON structure by removing discussionUrl fields - Maintain only discussionId for linking to GitHub discussions 💄 style(baseof.html): add Font Awesome script for icons - Include Font Awesome script to support new icons in the website layout 💄 style(index.html): enhance obituary action buttons with icons - Update "Add Obituary" button with scythe and plus icons for visual clarity - Modify discussion link to construct URL using discussionId instead of discussionUrl
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-stone-0045b7f10-8.centralus.6.azurestaticapps.net |
- change buttons to use outline styles for a cleaner look - adjust button size to small for improved design consistency
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-stone-0045b7f10-8.centralus.6.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ feat(site): add obituary submission link
🐛 fix(site): update GitHub edit URL