Skip to content

Conversation

@fodinabor
Copy link
Contributor

This allows to use the global window variable to e.g. get the host we're on -> don't hardcode localhost.

This allows to use the global `window` variable to e.g. get the host we're on -> don't hardcode localhost.
@MrSidims
Copy link
Owner

MrSidims commented May 8, 2025

Thank you for your contribution! I've run the CI and will take a look at it this evening.

@MrSidims MrSidims merged commit 10ee3c9 into MrSidims:main May 8, 2025
1 check passed
@MrSidims
Copy link
Owner

MrSidims commented May 8, 2025

@fodinabor oh, I have screwed up merging settings in the repository, and the patch got authored by me when was merged. Should I revert it with you reapplying it?

@MrSidims
Copy link
Owner

MrSidims commented May 8, 2025

Ah, git log is looking like this:

commit 10ee3c9e8b8942a9156f64d7e7036b760cd064a1 (HEAD -> main, origin/main)
Merge: 2b2ec65 81ad23d
Author: Dmitry Sidorov <[email protected]>
Date:   Thu May 8 16:41:08 2025 +0200

    Don't use `window` as variable name. (#6)

    This allows to use the global `window` variable to e.g. get the host
    we're on -> don't hardcode localhost.

commit 81ad23d4a7d7143f328851f93286f65ba847d58e
Author: Joachim Meyer <[email protected]>
Date:   Thu May 8 11:18:31 2025 +0200

    Don't use `window` as variable name.

    This allows to use the global `window` variable to e.g. get the host we're on -> don't hardcode localhost.

I still need to fix merging settings as I didn't mean to create merge commits, but at least I didn't claim the work. Sorry for the noise.

@fodinabor
Copy link
Contributor Author

That's fine, no worries :)
Neat project BTW, thanks!

@fodinabor fodinabor deleted the fix/dynamic-backend-host branch May 8, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants