Rrivera and carrarin/merging ops and dev#62
Merged
Conversation
- Implemented SubsystemCalorimeterThresholdsTable access in ROCCalorimeterInterface - Added private BoardID member initialized from serial (reg 147) - Automatic BoardID resolution during configure() - Thresholds now loaded from online DB during ROC configuration
…/mergingOpsAndDev
giro94
requested changes
Feb 18, 2026
otsdaq-mu2e-calorimeter/FEInterfaces/ROCCalorimeterInterface_interface.cc
Outdated
Show resolved
Hide resolved
giro94
approved these changes
Feb 18, 2026
Contributor
giro94
left a comment
giro94
left a comment
There was a problem hiding this comment.
Looks good now.
There are some things that we'll need to change soon.
For example, pin-diode list reading (not from file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.