Skip to content

Scorrodi/wideband#6

Merged
eflumerf merged 24 commits intodevelopfrom
scorrodi/wideband
Feb 14, 2025
Merged

Scorrodi/wideband#6
eflumerf merged 24 commits intodevelopfrom
scorrodi/wideband

Conversation

@corrodis
Copy link
Copy Markdown
Contributor

Merge CRV developments at Wideband back into develop

@corrodis corrodis self-assigned this Feb 12, 2025
<script type="text/JavaScript" src="/WebPath/js/Debug.js"></script>
<script type="text/JavaScript" src="/WebPath/UserWebPath/js/mu2e.js"></script>
<!--<link rel="stylesheet" href="https://www.w3schools.com/w3css/4/w3.css">-->
<link rel="stylesheet" href="/WebPath/UserWebPath/css/mu2e.css">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the near future we will need to add another layer of indirection for each subsystem. For example the STM is also using the UserWebPath area. Perhaps /WebPath/UserWebPath/crv/css/* and /WebPath/UserWebPath/stm/* would be sufficient.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I think we can leave it for this pull request, or does this cause issues in the installation?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave it for this one I think. It should be easy to change if it becomes a problem. (If we keep running subsystems independently, then actually I think it will not be an issue)

Copy link
Copy Markdown
Contributor

@rrivera747 rrivera747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sam-grant
Copy link
Copy Markdown
Contributor

I fixed the merge conflict in CrvDQM_module.cc

@eflumerf eflumerf merged commit 96d5f7d into develop Feb 14, 2025
3 of 6 checks passed
@eflumerf eflumerf deleted the scorrodi/wideband branch February 14, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants