Fix CrvDQM_module for updated artdaq-core-mu2e.#7
Conversation
|
Note that the file has been clang-format'ed, probably a good idea to turn whitespace diff off |
ehrlich-uva
left a comment
ehrlich-uva
left a comment
There was a problem hiding this comment.
I assume the change in GetCRVHits was the only change.
| auto res = crvData.GetCRVHits(bl, hits); | ||
| if(!res) | ||
| { | ||
| TLOG(TLVL_ERROR) << "Unable to get CRV hist!"; | ||
| // Iterate invalid count? | ||
| // ++invalidEventCounter_; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I assume that this was the only change.
There was a problem hiding this comment.
That's correct, the only real change is the GetCRVHits
There was a problem hiding this comment.
Can you explain why this was needed?
There was a problem hiding this comment.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone/unused-return-value.html
The GetCRVHits method was changed to return a boolean indicating whether it was successful. The TLVL_ERROR is there to indicate that the method did not return successfully, and the commented lines were copied from lower in the module, presumably for future error accounting.
There was a problem hiding this comment.
I don't think this change was picked up when I fixed the merge conflicts earlier, but I'll put it back in.
This module is a bit unfinished, I'm still writing it. Please bear with me.
3 participants
No description provided.