adjusted to changes in CRV decoders: restoring changes in commit 2231156#9
Merged
adjusted to changes in CRV decoders: restoring changes in commit 2231156#9
Conversation
eflumerf
previously approved these changes
Feb 17, 2025
matthewstortini
previously approved these changes
Feb 17, 2025
Contributor
There was a problem hiding this comment.
@eflumerf given that the most recent release does not build without these changes, maybe I should delete the tag, merge this PR, and then re-push the tag. What do you think? Probably not good to get in the habit of deleting tags, but given that the release will not build without these changes it may be best to in this situation.
eflumerf
dismissed stale reviews from matthewstortini and themself
via
c9c9e13
eflumerf
previously approved these changes
Feb 24, 2025
eflumerf
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagating (again?) the change of GetCRVHit, now it returns a bool and takes a std::vectormu2e::CRVDataDecoder::CRVHit as an argument. I believe this change is needed for tdaq suite v3_04_00 to properly compile.