[+] 新增舊框燈版 837-15070-02 重低音 LED / 頂板 LED / 中央 LED 的支持 #100
Conversation
Co-authored-by: PT_Chen <[email protected]>
Summary of ChangesHello @kevin0216, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取請求新增了一個模組，旨在為舊版燈板 (837-15070-02) 提供兼容性。它透過重新映射新框的頂板 LED 訊號，使其能夠控制舊版硬體上的重低音喇叭、頂板和中央 LED。這項功能是透過在運行時修補現有程式碼並利用反射機制來實現的，以確保舊版設備能夠正確響應燈光指令。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
kevin0216
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| try | ||
| { | ||
| var ledIfType = typeof(Bd15070_4IF); | ||
| var controlField = ledIfType.GetField("_control", BindingFlags.NonPublic | BindingFlags.Instance); | ||
|
|
||
| if (controlField == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] _control field not found in Bd15070_4IF"); | ||
| return; | ||
| } | ||
|
|
||
| var control = controlField.GetValue(ledIf[playerIndex]); | ||
| if (control == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] Control object is null"); | ||
| return; | ||
| } | ||
|
|
||
| // Get _board field from Bd15070_4Control | ||
| var controlType = control.GetType(); | ||
| var boardField = controlType.GetField("_board", BindingFlags.NonPublic | BindingFlags.Instance); | ||
| if (boardField == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] _board field not found in Bd15070_4Control"); | ||
| return; | ||
| } | ||
|
|
||
| var board = boardField.GetValue(control); | ||
| if (board == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] Board object is null"); | ||
| return; | ||
| } | ||
|
|
||
| // Get _ctrl field from Board15070_4 | ||
| var boardType = board.GetType(); | ||
| var ctrlField = boardType.GetField("_ctrl", BindingFlags.NonPublic | BindingFlags.Instance); | ||
| if (ctrlField == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] _ctrl field not found in Board15070_4"); | ||
| return; | ||
| } | ||
|
|
||
| var boardCtrl = ctrlField.GetValue(board); | ||
| if (boardCtrl == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] BoardCtrl object is null"); | ||
| return; | ||
| } | ||
|
|
||
| // Get _ioCtrl field from BoardCtrl15070_4 | ||
| var boardCtrlType = boardCtrl.GetType(); | ||
| var ioCtrlField = boardCtrlType.GetField("_ioCtrl", BindingFlags.NonPublic | BindingFlags.Instance); | ||
| if (ioCtrlField == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] _ioCtrl field not found in BoardCtrl15070_4"); | ||
| return; | ||
| } | ||
|
|
||
| var ioCtrl = ioCtrlField.GetValue(boardCtrl); | ||
| if (ioCtrl == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] IoCtrl object is null"); | ||
| return; | ||
| } | ||
|
|
||
| // Get SetLedGs8BitCommand array from IoCtrl (public field) | ||
| var ioCtrlType = typeof(IoCtrl); | ||
| var setLedGs8BitCommandField = ioCtrlType.GetField("SetLedGs8BitCommand", BindingFlags.Public | BindingFlags.Instance); | ||
| if (setLedGs8BitCommandField == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] SetLedGs8BitCommand field not found in IoCtrl"); | ||
| return; | ||
| } | ||
|
|
||
| var setLedGs8BitCommandArray = setLedGs8BitCommandField.GetValue(ioCtrl) as SetLedGs8BitCommand[]; | ||
| if (setLedGs8BitCommandArray == null || setLedGs8BitCommandArray.Length <= 8) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] SetLedGs8BitCommand array is null or too small"); | ||
| return; | ||
| } | ||
|
|
||
| // Get SendForceCommand method from BoardCtrl15070_4 | ||
| var sendForceCommandMethod = boardCtrlType.GetMethod("SendForceCommand", BindingFlags.Public | BindingFlags.Instance); | ||
| if (sendForceCommandMethod == null) | ||
| { | ||
| MelonLoader.MelonLogger.Error("[LegacyLedBoardMapping] SendForceCommand method not found in BoardCtrl15070_4"); | ||
| return; | ||
| } | ||
|
|
||
| // Use SetLedGs8BitCommand[8] and SetLedGs8BitCommand[9] directly (same as buttons 0-7, but for ledPos = 8 and 9) | ||
| // This bypasses the FET command path in IoCtrl.SetLedData(), as they are not via FET, they are like buttons | ||
| // ledPos = 8 == woofer & roof | ||
| // ledPos = 9 == center | ||
| setLedGs8BitCommandArray[8].setColor(8, color); | ||
| setLedGs8BitCommandArray[9].setColor(9, color); | ||
| sendForceCommandMethod.Invoke(boardCtrl, new object[] { setLedGs8BitCommandArray[8] }); | ||
|
|
||
| // Set the _gsUpdate flag on Bd15070_4IF so PreExecute() sends the update command | ||
| // This matches exactly how buttons work - they set _gsUpdate = true | ||
| var gsUpdateField = ledIfType.GetField("_gsUpdate", BindingFlags.NonPublic | BindingFlags.Instance); | ||
| if (gsUpdateField != null) | ||
| { | ||
| gsUpdateField.SetValue(ledIf[playerIndex], true); | ||
| } | ||
| else | ||
| { | ||
| MelonLoader.MelonLogger.Warning("[LegacyLedBoardMapping] _gsUpdate field not found, LED may not update"); | ||
| } | ||
| } | ||
| catch (System.Exception ex) | ||
| { | ||
| MelonLoader.MelonLogger.Error($"[LegacyLedBoardMapping] Failed to set woofer LED: {ex.Message}\n{ex.StackTrace}"); | ||
| } |
There was a problem hiding this comment.
在 RedirectToButtonLedMechanism 方法中，您使用了大量的反射呼叫來存取私有成員。GetField 和 GetMethod 是效能開銷較大的操作，尤其是在可能每幀都會被呼叫的 LED 更新邏輯中。這可能會對遊戲效能產生不必要的影響。
建議將反射獲取的 FieldInfo 和 MethodInfo 物件快取在靜態唯讀欄位中。這樣，反射查詢的開銷只會在類別載入時發生一次，後續呼叫將會快得多。
例如，您可以這樣修改：
public class LegacyBoardMapping
{
// ... 其他程式碼 ...
private static readonly System.Reflection.FieldInfo _controlField =
typeof(Comio.BD15070_4.Bd15070_4IF).GetField("_control", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance);
// ... 為其他欄位和方法建立類似的靜態欄位 ...
private static void RedirectToButtonLedMechanism(byte playerIndex, Color32 color)
{
// ...
try
{
if (_controlField == null)
{
MelonLoader.MelonLogger.Error("[LegacyBoardMapping] _control field not found in Bd15070_4IF");
return;
}
var control = _controlField.GetValue(IO.MechaManager.LedIf[playerIndex]);
// ... 使用其他快取的欄位 ...
}
catch (System.Exception ex)
{
MelonLoader.MelonLogger.Error($"[LegacyBoardMapping] Failed to set woofer LED: {ex.Message}\n{ex.StackTrace}");
}
}
}這樣做可以顯著提高此方法的執行效率，並使程式碼更清晰。
| // ledPos = 9 == center | ||
| setLedGs8BitCommandArray[8].setColor(8, color); | ||
| setLedGs8BitCommandArray[9].setColor(9, color); | ||
| sendForceCommandMethod.Invoke(boardCtrl, new object[] { setLedGs8BitCommandArray[8] }); |
There was a problem hiding this comment.
這裡您為 ledPos = 8 和 ledPos = 9 都設定了顏色，但只對索引為 8 的指令呼叫了 SendForceCommand。根據註解，ledPos = 8 對應重低音和頂板，而 ledPos = 9 對應中央 LED。
如果 SendForceCommand 是用來觸發單個指令的，那麼您可能遺漏了對 setLedGs8BitCommandArray[9] 的呼叫，這會導致中央 LED 的顏色無法被即時更新。
建議您確認 SendForceCommand 的行為。如果需要單獨發送，請為索引 9 也增加一次呼叫。
sendForceCommandMethod.Invoke(boardCtrl, new object[] { setLedGs8BitCommandArray[8] });
sendForceCommandMethod.Invoke(boardCtrl, new object[] { setLedGs8BitCommandArray[9] });| // Check if MechaManager is initialized | ||
| if (!IO.MechaManager.IsInitialized) | ||
| { | ||
| MelonLoader.MelonLogger.Warning("[LegacyLedBoardMapping] MechaManager not initialized, cannot set woofer LED"); |
There was a problem hiding this comment.
此方法中的日誌訊息使用了 [LegacyLedBoardMapping] 作為前綴，但在這個類別的其他地方（例如 Bd15070_4IF_Construct_Patch 中）使用的是 [LegacyBoardMapping]。
為了保持一致性並方便日誌過濾和問題排查，建議將所有 [LegacyLedBoardMapping] 都修改為 [LegacyBoardMapping]。
MelonLoader.MelonLogger.Warning("[LegacyBoardMapping] MechaManager not initialized, cannot set woofer LED");
| name: "舊版燈板映射", | ||
| en: "Remapping Billboard LED to 837-15070-02 Woofer LED, Roof LED, Center LED", | ||
| zh: "重新映射新框頂板 LED 至 837-15070-02 (舊版燈板) 的重低音喇叭 LED、頂板 LED 以及中央 LED")] |
There was a problem hiding this comment.
| name: "舊版燈板映射", | |
| en: "Remapping Billboard LED to 837-15070-02 Woofer LED, Roof LED, Center LED", | |
| zh: "重新映射新框頂板 LED 至 837-15070-02 (舊版燈板) 的重低音喇叭 LED、頂板 LED 以及中央 LED")] | |
| name: "旧框灯板映射", | |
| en: "Remapping Billboard LED to 837-15070-02 Woofer LED, Roof LED, Center LED", | |
| zh: "重新映射新框顶板 LED 至 837-15070-02 (旧版灯板) 的重低音喇叭 LED、顶板 LED 以及中央 LED")] |
|
有一个 SkipBoardNoCheck（旧框灯板支持）功能，是否应该考虑合并一下呢 |
那麼 SkipBoardNoCheck 會不會需要修改模組名稱呢，因為他現在功能已經不只 Skip BoardNoCheck |
* more disableio4 * [+] 新增舊框燈版 837-15070-02 重低音 LED / 頂板 LED / 中央 LED 的支持 (#100) * [+] Adding support for 837-15070-02 Woofer LED, Roof LED and Center LED Co-authored-by: PT_Chen <[email protected]> * [F] Fixing not consistant module name * [F] Fixed missing command * [F] Optimized with reducing reflection fetching * refactor: Merging into SkipBoardNoCheck --------- Co-authored-by: PT_Chen <[email protected]> * [O] rename SkipBoardNoCheck to OldCabLightBoardSupport * [+] MaimollerIO 按键灯光触摸单独设置 * [O] AdxHidInput.DisableButtons * [O] Add MaiChartManager EN * Add unstable rate display (#101) * Add unstable rate display * Reuse material * Fix windows line endings * move UnstableRate * [O] UnstableRate 2P support * [O] 使用对象池优化性能 * [O] Change color * [+] build script configuration * [+] 增加同时开启的 DisplayTouchInGame * [O] 力大砖飞 -> ResourcesOverride * [O] configSort * [O] convert check to non-AI script * [O] configSort * [F] bugs * [F] minor * revert --------- Co-authored-by: Kevin S.H. Chang <[email protected]> Co-authored-by: PT_Chen <[email protected]> Co-authored-by: zealain <[email protected]>
2 participants
簡介
此次新增了對舊框燈版 837-15070-02 中，重低音 LED / 頂板 LED 跟中央 LED 的支持
會將 Sinmai 中對 Billboard (頂板) LED 的指令映射到重低音 LED / 頂板 LED 跟中央 LED
細節
主要是 Hook 了 JvsOutputPwm 來攔截對 Billboard 的設定要求，並將請求改為與按鍵燈同格式的發送方式 (因按鍵燈可以正常運作，而在 micetools/mailed 中提到舊燈板的按鍵燈與重低音/頂板及中央為同一發送格式)
並在最後設定 _gsUpdate 來確保燈板指令更新
另外感謝 $EGA 寫的酷東西
在 Bd15070_4IF._construct 中對按鍵 LED 數量有硬限制（陣列只開 8 格，並 for 迴圈只執行 8 次），有對陣列初始化跟 for 迴圈進行修改，多出 ledPos = 8 及 9 的空間
此模組已在實際機台上測試，確認可用
Special Thanks
2025/12/23
by @kevin0216 & @ptchen314