fix: account for JudgeAdjust.B offset in UnstableRate display#106
fix: account for JudgeAdjust.B offset in UnstableRate display#106clansty merged 2 commits intoMuNET-OSS:mainfrom
Conversation
Summary of ChangesHello @Dyrox, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在解决不稳定率显示功能中的一个计算错误,确保用户自定义的 B 判调整(JudgeAdjust.B)能够准确地反映在游戏界面上。通过修正这一显示偏差,玩家将获得更精确的视觉反馈,从而提升游戏体验。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
ok搞定 |
|
其实应该直接把那个字段设成 public 的。我来改吧 |
Fixes a calculation error in the Unstable Rate display (introduced in #101)
就是对之前某个社区功能的小修,原来如果在Mods.GameSettings.JudgeAdjust中的B判改变数值,那不会在Unstable Rate那个条上面正确反映,比如说我下面这个视频里即使所有音符几乎都是大P,但显示条显示的还是偏右的粉(我这台机子是B判=-4.0)
BEFORE.mov
现在可以mod可以读取JudgeAdjust里面的B判并自行调整了,(A判不受影响因为只是动画)
AFTER.mov