Skip to content

[F]优化CustomIntroCinematic:当玩家有成绩时不触发开场视频#92

Merged
clansty merged 7 commits intoMuNET-OSS:mainfrom
HawkingLaughing:IntroCinemaFix
Nov 27, 2025
Merged

[F]优化CustomIntroCinematic:当玩家有成绩时不触发开场视频#92
clansty merged 7 commits intoMuNET-OSS:mainfrom
HawkingLaughing:IntroCinemaFix

Conversation

@HawkingLaughing
Copy link
Contributor

借鉴了TrackComoufalge的CamouflageCheck方法,使得CustomIntroCinematic在任一玩家有成绩时不触发开场视频

@clansty
Copy link
Member

clansty commented Nov 19, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献!这次的改动很棒,通过检查玩家成绩来避免重复播放开场视频,提升了用户体验。

代码整体逻辑清晰,但在几个地方可以稍作优化以提高代码质量和可维护性:

  1. 移除了几个未被使用的 using 指令。
  2. 使用枚举代替了硬编码的数字,增强了代码的可读性。
  3. 修正了 TryGetValue 的使用方式,使其逻辑更严谨。

具体的修改建议请看下面的评论。再次感谢!

@clansty
Copy link
Member

clansty commented Nov 19, 2025

我觉得这需要加个开关,你加还是我加

@HawkingLaughing
Copy link
Contributor Author

我觉得这需要加个开关,你加还是我加

你加吧

@clansty clansty merged commit 67a8ad0 into MuNET-OSS:main Nov 27, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants