力大砖飞模组验证完成 #99
力大砖飞模组验证完成 #99
Conversation
Updated warning message for potential performance impact and conflicts.
Summary of ChangesHello @Haisairova-Official, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求引入了一个名为“力大砖飞”的新模组，用于 AquaMai 游戏。该模组允许用户通过从本地目录加载自定义 PNG 图像，全局替换游戏中的精灵和纹理。其实现通过 HarmonyLib 进行静态注入，拦截图形渲染和画布缩放事件，确保自定义资源能在整个游戏中应用。作者已完成验证，并在特定测试配置下未发现其他兼容性问题。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
AquaMai.Mods/Fancy/RsOverride.cs
Outdated
| SpritePool[name] = sprite; | ||
| TexturePool[name] = tex; | ||
| } | ||
| } catch { } |
There was a problem hiding this comment.
catch 块为空，会静默地忽略所有加载图片过程中的错误（例如，文件损坏或格式不正确）。这会使调试变得非常困难，因为用户可能不知道为什么他们的自定义皮肤没有生效。建议在 catch 块中捕获异常并添加日志记录，以便追踪问题。
} catch (Exception e) { MelonLogger.Error($"Failed to load custom skin '{Path.GetFileName(file)}': {e.Message}"); }
AquaMai.Mods/Fancy/RsOverride.cs
Outdated
| try { resolvedPath = FileSystem.ResolvePath(skinsDir); } | ||
| catch { resolvedPath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, skinsDir); } |
There was a problem hiding this comment.
使用 try-catch 来处理路径解析逻辑会让代码意图变得不清晰，并且是一种反模式（anti-pattern）。对于游戏模组，使用 AppDomain.CurrentDomain.BaseDirectory 通常比 Environment.CurrentDirectory 更可靠，因为后者可能会在运行时被改变。建议简化此处的路径解析逻辑，直接使用更可靠的基准目录。
resolvedPath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, skinsDir);| if (img.sprite != null && SpritePool.TryGetValue(img.sprite.name.ToLower(), out var s)) | ||
| img.sprite = s; |
There was a problem hiding this comment.
在 OnGraphicRebuild 方法中，替换图片后会调用 img.canvasRenderer.SetColor(Color.white) 来重置颜色，以避免意外的颜色叠加。但在 OnCanvasEnable 方法中缺少了这个逻辑。为了保持行为一致性并避免潜在的视觉问题，建议在这里也添加颜色重置的逻辑。同时，为了代码可读性和可维护性，建议为 if 语句使用花括号 {}。
if (img.sprite != null && SpritePool.TryGetValue(img.sprite.name.ToLower(), out var s))
{
img.sprite = s;
img.canvasRenderer.SetColor(Color.white);
}| if (rImg.texture != null && TexturePool.TryGetValue(rImg.texture.name.ToLower(), out var t)) | ||
| rImg.texture = t; |
There was a problem hiding this comment.
同样地，为了与 OnGraphicRebuild 的行为保持一致，建议在替换 RawImage 的 texture 后，也重置其 canvasRenderer 的颜色为 Color.white。同时，为了代码可读性和可维护性，建议为 if 语句使用花括号 {}。
if (rImg.texture != null && TexturePool.TryGetValue(rImg.texture.name.ToLower(), out var t))
{
rImg.texture = t;
rImg.canvasRenderer.SetColor(Color.white);
}
|
以及隆重欢迎新开发者加入 AquaMai 大家庭 |
|
新屎山制造小作坊） |
Co-authored-by: 凌莞~(=^▽^=) <[email protected]>
Co-authored-by: 凌莞~(=^▽^=) <[email protected]>
Co-authored-by: 凌莞~(=^▽^=) <[email protected]>
Co-authored-by: 凌莞~(=^▽^=) <[email protected]>
|
这下搞定啦 改成 "LocalAssets/ResourcesOverride" |
|
好耶 |
|
对我会新写一个 毕竟这个能跑就不要动他了） |
2 participants
目前未发现更多兼容性问题。测试于SDGB151+EZ156+160
修改部分表述
烦内就这样子吧）
Note
Introduces
CustomSkinsPlusStaticto load PNG overrides and forcibly replaceImage/RawImageassets across the UI via Harmony patches.CustomSkinsPlusStaticinAquaMai.Mods/Fancy/RsOverride.cswithConfigSectionand directoryConfigEntry(LocalAssets/GlobalTextureOverride).*.pngfrom the configured folder intoSpritePool/TexturePoolwith normalized names.PrefixonGraphic.Rebuildto swapImage.spriteandRawImage.texturewith pool matches and reset renderer color.PostfixonCanvasScaler.OnEnableto bulk-scan children and replace matching sprites/textures.Written by Cursor Bugbot for commit 692d10b. This will update automatically on new commits. Configure here.