Skip to content

Replaces Webpack with Vite#2109

Open
allanlasser wants to merge 6 commits intomasterfrom
vite-build-system
Open

Replaces Webpack with Vite#2109
allanlasser wants to merge 6 commits intomasterfrom
vite-build-system

Conversation

@allanlasser
Copy link
Member

@allanlasser allanlasser commented Jan 2, 2026

Replaces Webpack with Vite 7. Significantly reduces the complexity of developing, building, and bundling static JS and Sass files while improving DX and overall bundle size.

When reviewing, we should make sure that assets (styles, scripts) load and execute as expected. There shouldn't be any obvious differences between our review app and production.

@duckduckgrayduck duckduckgrayduck temporarily deployed to muckrock-pip-vite-build-m5x146 January 2, 2026 23:05 Inactive
@allanlasser allanlasser self-assigned this Jan 5, 2026
@allanlasser allanlasser marked this pull request as ready for review January 7, 2026 21:44
@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-3dbylk January 8, 2026 14:58 Inactive
@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-3dbylk January 8, 2026 17:35 Inactive
@allanlasser
Copy link
Member Author

allanlasser commented Jan 8, 2026

The review app is throwing an Internal Server Error. I'm going to investigate further.

Update: this was due to a misconfig between Django Compressor and Vite's manifest. I'm seeing what happens if I remove Django Compressor from the app.

Update 2: Ok, removing Django Compressor made progress. Now I have an issue where the main CSS and JS return 403 errors from our staging AWS bucket.

@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-uhk1bd January 8, 2026 20:25 Inactive
@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-uhk1bd January 8, 2026 22:14 Inactive
@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-uhk1bd January 8, 2026 22:24 Inactive
@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-gowtp5 January 8, 2026 22:52 Inactive
@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-n2tvgd January 9, 2026 22:19 Inactive
@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-14izya January 11, 2026 18:20 Inactive
@allanlasser allanlasser temporarily deployed to muckrock-pip-vite-build-wrcccp January 11, 2026 18:37 Inactive
@allanlasser
Copy link
Member Author

During deployment, something is happening with the staging S3 bucket where the permissions aren't being set correctly on the collected static assets. Requests for these assets return a 403 error.

@duckduckgrayduck duckduckgrayduck temporarily deployed to muckrock-pip-vite-build-u46bt1 January 28, 2026 19:46 Inactive
@allanlasser allanlasser linked an issue Feb 3, 2026 that may be closed by this pull request
@mitchelljkotler mitchelljkotler temporarily deployed to muckrock-pip-vite-build-ebh6y7 February 12, 2026 21:08 Inactive
{% endif %}

{% compress_cache foia_cache_timeout foia_detail_bottom foia.pk request.user.pk %}
{% cache foia_cache_timeout foia_detail_bottom foia.pk request.user.pk %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be compress_cache - this is compressing the cached data and does not have anything to do with django-compressor or asset management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delay in deploying CSS/JS

3 participants