Create new PlanPurchaseForm with resuable templates#570
Open
allanlasser wants to merge 7 commits intomasterfrom
Open
Create new PlanPurchaseForm with resuable templates#570allanlasser wants to merge 7 commits intomasterfrom
allanlasser wants to merge 7 commits intomasterfrom
Conversation
mitchelljkotler
temporarily deployed
to
squarelet-pi-allanlasse-tal7ft
mitchelljkotler
temporarily deployed
to
squarelet-pi-allanlasse-aiuioe
mitchelljkotler
requested changes
Feb 12, 2026
Member
mitchelljkotler
left a comment
mitchelljkotler
left a comment
There was a problem hiding this comment.
I found one issue with the use card on file choice, but otherwise think refactoring into a form and moving the logic out of the view is a big win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522
Refactors our
plan.htmlandpayments/views.pylogic into aPlanPurchaseFormthat renders aplan_purchase.htmltemplate. This isolates our payment handling logic, makes it more reusable, and is more aligned with Django's approach.