Makes withdrawing a request semantically distinct operation#588
Open
allanlasser wants to merge 2 commits intoallanlasser/issue571from
Open
Makes withdrawing a request semantically distinct operation#588allanlasser wants to merge 2 commits intoallanlasser/issue571from
allanlasser wants to merge 2 commits intoallanlasser/issue571from
Conversation
Fixes #575 Previously, we conflated withdrawing a request with rejecting, which led to some unexpected behavior. This is now clearer, with a specific ability to understand what happened to a particular request.
allanlasser
requested a deployment
to
squarelet-pi-allanlasse-tjitm6
allanlasser
requested a deployment
to
squarelet-pi-allanlasse-tjitm6
Contributor
|
I requested to join Allan test org, withdrew my invitation, but it still appears to to hide the Request to Join from me. Says "Your request to join this organization was rejected. Please contact an admin if this is a mistake and you need to be added to this organization" |
Member
Author
I'll have to double check our context data and template. Thanks for catching this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #575
Previously, we conflated withdrawing a request with rejecting, which led to some unexpected behavior. This is now clearer, with a specific ability to understand what happened to a particular request.
Note: currently based on #582 to avoid migration merge conflicts. Should be rebased and merged following that change.