Skip to content

Refactor / update to best practices#10

Merged
ewels merged 10 commits intodevfrom
dev-merged
Dec 18, 2025
Merged

Refactor / update to best practices#10
ewels merged 10 commits intodevfrom
dev-merged

Conversation

@ewels
Copy link
Member

@ewels ewels commented Dec 18, 2025

Summary

  • Add pre-commit configuration (ruff, prettier, standard hooks)
  • Add lint workflow using pre-commit action
  • Add PyPI publish workflow with trusted publishing
  • Add report validation to test workflow (verifies reports are generated)
  • Add dev dependencies to pyproject.toml
  • Add CLAUDE.md with architecture documentation

These additions were cherry-picked from the claude/refactor-plugin-best-practices-xOSUS branch, which had overlapping work with dev. The dev branch's architecture (hook-based plugin, module restructuring, new test data) was preserved, and only the unique CI/CD tooling from the refactor branch was merged in.

Test plan

  • Verify lint workflow runs successfully
  • Verify build workflow runs with report validation
  • Verify pre-commit hooks work locally with pre-commit run --all-files

🤖 Generated with Claude Code

ewels and others added 3 commits December 18, 2025 09:23
Merge unique additions from refactor branch into dev:
- Add pre-commit configuration (ruff, prettier, standard hooks)
- Add lint workflow using pre-commit action
- Add PyPI publish workflow with trusted publishing
- Add report validation to test workflow
- Add dev dependencies to pyproject.toml
- Add CLAUDE.md with updated architecture documentation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use modern type annotations (dict instead of Dict, list instead of List)
- Use super() without arguments
- Use contextlib.suppress() instead of try/except pass
- Use f-strings instead of .format()
- Remove unused imports

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add mypy to dev dependencies
- Add [tool.mypy] config with ignore_missing_imports

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ewels and others added 5 commits December 18, 2025 09:36
- Add return type hints to all functions
- Add parameter type hints (using Any for interop types)
- Import Any from typing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Collaborator

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ewels
Copy link
Member Author

ewels commented Dec 18, 2025

Let's merge this with failing tests. Can address them in a separate PR, I don't want this PR to balloon out of scope. At the moment it's fairly clean refactoring and repo health only.

@ewels ewels changed the title Add CI/CD tooling and developer documentation Refactor / update to best practices Dec 18, 2025
@ewels ewels merged commit b4d90a9 into dev Dec 18, 2025
1 of 3 checks passed
@ewels ewels deleted the dev-merged branch December 18, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants